Skip to content

Commit 1fdce51

Browse files
Tests: Do not include style because we won't be warned about regressions if we make changes in theme CSS.
1 parent 10bb213 commit 1fdce51

File tree

4 files changed

+6
-23
lines changed

4 files changed

+6
-23
lines changed

tests/unit/button/button_core.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@
3838
var $inherited = $( "#theme-check" ),
3939
$explicit = $( "#theme-check-explicit" );
4040

41-
deepEqual( $inherited.css( "background-color" ), "rgb(0, 0, 0)" );
42-
ok( $explicit.hasClass( "ui-btn-b" ), "should not inherit" );
41+
deepEqual( $inherited.css( "background-color" ), "rgb(44, 44, 44)" ); /* The RGB value should match the background color we set for ui-btn-b in the default theme */
42+
ok( $explicit.hasClass( "ui-btn-a" ), "should not inherit" );
4343
});
4444

4545
test( "Enhanced button elements should allow for phrasing content.", function() {

tests/unit/button/index.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ <h2 id="qunit-userAgent"></h2>
5454
</ol>
5555

5656
<div data-nstest-role="page" data-nstest-theme="a">
57-
<div data-nstest-role="content" data-nstest-theme="p">
57+
<div data-nstest-role="content" data-nstest-theme="b">
5858
<button class="should-be-native">foo</button>
5959
<button id="enhanced">bar</button>
6060
<button id="text">foo</button>
@@ -63,7 +63,7 @@ <h2 id="qunit-userAgent"></h2>
6363
<input type="submit" id="hidden-element-addition" name="foo">foo</input>
6464
</form>
6565
<button id="theme-check" value="foo"></button>
66-
<button id="theme-check-explicit" value="foo" data-nstest-theme="b"></button>
66+
<button id="theme-check-explicit" value="foo" data-nstest-theme="a"></button>
6767
<button id="contains-html">Supports <sup>phrasing content</sup></button>
6868
<button id="val-contains-html" value="<fake markup>"></button>
6969
</div>

tests/unit/checkboxradio/checkboxradio_core.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@
9494
var $inherited = $( "#checkbox-inherit-theme" ),
9595
$explicit = $( "#checkbox-explicit-theme" );
9696

97-
deepEqual( $inherited.siblings("label").css( "background-color" ), "rgb(0, 0, 0)" );
97+
deepEqual( $inherited.siblings("label").css( "background-color" ), "rgb(44, 44, 44)" ); /* The RGB value should match the background color we set for ui-btn-b in the default theme */
9898
ok( $explicit.siblings("label").hasClass( "ui-btn-b" ), "should not inherit" );
9999
});
100100

tests/unit/checkboxradio/index.html

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -27,23 +27,6 @@
2727
<link rel="stylesheet" href="../../../external/qunit.css"/>
2828

2929
<script src="../../swarminject.js"></script>
30-
<style>
31-
.ui-page-theme-a .ui-btn,
32-
html .ui-bar-a .ui-btn,
33-
html .ui-body-a .ui-btn,
34-
html body .ui-btn.ui-btn-a,
35-
html body .ui-group-theme-a .ui-btn,
36-
[class*="ui-group-theme-"] .ui-btn.ui-btn-a,
37-
/* Button visited */
38-
.ui-page-theme-a .ui-btn:visited,
39-
html .ui-bar-a .ui-btn:visited,
40-
html .ui-body-a .ui-btn:visited,
41-
html body .ui-btn.ui-btn-a:visited,
42-
html body .ui-group-theme-a .ui-btn:visited,
43-
[class*="ui-group-theme-"] .ui-btn.ui-btn-a:visited {
44-
background: #000 /*{p-bup-background-color}*/;
45-
}
46-
</style>
4730
</head>
4831
<body>
4932

@@ -53,7 +36,7 @@ <h2 id="qunit-userAgent"></h2>
5336
<ol id="qunit-tests">
5437
</ol>
5538

56-
<div data-nstest-role="page" data-nstest-theme="a">
39+
<div data-nstest-role="page" data-nstest-theme="b">
5740
<div data-nstest-role="content">
5841

5942
<div data-nstest-role="fieldcontain">

0 commit comments

Comments
 (0)