Skip to content

Commit 354d105

Browse files
committed
Autocomplete: Cleanup
1 parent e984ac2 commit 354d105

File tree

2 files changed

+13
-10
lines changed

2 files changed

+13
-10
lines changed

tests/unit/autocomplete/autocomplete_events.js

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -140,22 +140,25 @@ asyncTest( "cancel focus", function() {
140140
}, 50 );
141141
});
142142

143-
asyncTest( "past end of menu contenteditable", function() {
144-
expect( 1 );
143+
asyncTest( "past end of menu in multiline autocomplete", function() {
144+
expect( 2 );
145+
145146
var customVal = "custom value",
146147
element = $( "#autocomplete-contenteditable" ).autocomplete({
147148
delay: 0,
148-
source: data,
149-
focus: function() {
149+
source: [ "javascript" ],
150+
focus: function( event, ui ) {
151+
equal( ui.item.value, "javascript", "Item gained focus" );
150152
$( this ).text( customVal );
151-
return false;
153+
event.preventDefault();
152154
}
153155
});
154156

155-
element.simulate( "focus" ).text( "ja" ).keydown();
157+
element
158+
.simulate( "focus" )
159+
.autocomplete( "search", "ja" );
156160

157161
setTimeout(function() {
158-
element.simulate( "keydown", { keyCode: $.ui.keyCode.DOWN } );
159162
element.simulate( "keydown", { keyCode: $.ui.keyCode.DOWN } );
160163
element.simulate( "keydown", { keyCode: $.ui.keyCode.DOWN } );
161164
equal( element.text(), customVal );

ui/autocomplete.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -546,9 +546,9 @@ $.widget( "ui.autocomplete", {
546546
if ( this.menu.isFirstItem() && /^previous/.test( direction ) ||
547547
this.menu.isLastItem() && /^next/.test( direction ) ) {
548548

549-
if ( ! this.isMultiLine ) {
550-
this._value( this.term );
551-
}
549+
if ( !this.isMultiLine ) {
550+
this._value( this.term );
551+
}
552552

553553
this.menu.blur();
554554
return;

0 commit comments

Comments
 (0)