Spinner: Fix the IE6-height-fix to not break the spinner when initialized while not visible

jzaefferer · jzaefferer · commit bf51b0e71c8b · 2011-09-24T14:36:39.000+02:00
diff --git a/ui/jquery.ui.spinner.js b/ui/jquery.ui.spinner.js
@@ -150,7 +150,7 @@ $.widget( "ui.spinner", {
 
 		// IE 6 doesn't understand height: 50% for the buttons
 		// unless the wrapper has an explicit height
-		if ( this.buttons.height() === uiSpinner.height() ) {
+		if ( this.buttons.height() === uiSpinner.height() && uiSpinner.height() > 0 ) {
 			uiSpinner.height( uiSpinner.height() );
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -150,7 +150,7 @@ $.widget( "ui.spinner", {`
`150`	`150`
`151`	`151`	`// IE 6 doesn't understand height: 50% for the buttons`
`152`	`152`	`// unless the wrapper has an explicit height`
`153`		`- if ( this.buttons.height() === uiSpinner.height() ) {`
	`153`	`+ if ( this.buttons.height() === uiSpinner.height() && uiSpinner.height() > 0 ) {`
`154`	`154`	`uiSpinner.height( uiSpinner.height() );`
`155`	`155`	`}`
`156`	`156`