8000 completes first draft of Scoutside css styleguide by brianecook · Pull Request #1 · scoutside/css · GitHub
Skip to content

completes first draft of Scoutside css styleguide #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cbodtorf merged 8 commits into from
Aug 5, 2019
Merged

completes first draft of Scoutside css styleguide #1

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bbc6f99
completes first draft of Scoutside css styleguide
brianecook88 Jul 24, 2019
3971588
moves modifier class
brianecook88 Jul 24, 2019
bad16d6
changes order of media query
brianecook88 Jul 24, 2019
955063e
makes some small grammar edits
brianecook88 Jul 24, 2019
ff09034
fixes some grammar mistakes
brianecook88 Jul 25, 2019
6c322a3
makes updates to better explain stuff
brianecook88 Jul 25, 2019
ca15d81
removes some redundancies
brianecook88 Aug 5, 2019
302bfbf
adds anchor link for scoutside section
brianecook88 Aug 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
makes updates to better explain stuff
  • Loading branch information
@brianecook88
brianecook88 committed Jul 25, 2019
commit 6c322a3a0931f0f2c4a9450a2ad1d55ed655b146
10 changes: 5 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ Nesting css puts our styles in highly specific contexts and makes it difficult t
}
}

// Crap!! This same heading style is used in the new product slider section.
// Crap!! This same heading style is used in the new slider section on the homepage.
```

**Good**
Expand All @@ -376,7 +376,7 @@ Nesting css puts our styles in highly specific contexts and makes it difficult t
</h1>

<h2 class="main-heading main-heading--caps main-heading--blue">
I'm that new slider section heading, but I look exact same as the product details heading.
I'm that new slider section heading. I look exact same as the product details heading.
</h2>
```

Expand All @@ -395,7 +395,7 @@ If you decide there's no other option than to nest, you can use the parent selec
}
}

/* Nice! My selector only exists one place in the repo. I don't have to dig through a bunch of files of nested code
/* Nice! My selector only exists in one place in the scss directory. I don't have to dig through a bunch of files of nested code
to see where my change needs to be made.*/
```

Expand All @@ -421,8 +421,8 @@ As compared to:
}
}

/* Crap! When I search the repo for .selector, it's in 3 different places.
Now I have to spend time finding where I should make my change */
/* Crap! When I search the repo for .selector, it's in 3 different places. Now I have to spend time finding
where I should make my change */
```

### Only use classes to write styles. No IDs or html tags.
Expand Down