Small fixes for master (eclipse-che#6462)

Small fixes for master.

* Removed dependency on server side in gwt code (debugger)
* Fixed ThreadDumpTest
* Formatted java class

Author: tolusha

plugins/plugin-debugger/che-plugin-debugger-ide/pom.xml

@@ -41,17 +41,25 @@
             <groupId>com.google.inject</groupId>
             <artifactId>guice</artifactId>
         </dependency>
+        <dependency>
+            <groupId>com.google.inject.extensions</groupId>
+            <artifactId>guice-assistedinject</artifactId>
+        </dependency>
         <dependency>
             <groupId>javax.validation</groupId>
             <artifactId>validation-api</artifactId>
         </dependency>
         <dependency>
             <groupId>org.eclipse.che.core</groupId>
-            <artifactId>che-core-api-project</artifactId>
+            <artifactId>che-core-api-core</artifactId>
+        </dependency>
+        <dependency>
+            <groupId>org.eclipse.che.core</groupId>
+            <artifactId>che-core-api-debug-shared</artifactId>
         </dependency>
         <dependency>
             <groupId>org.eclipse.che.core</groupId>
-            <artifactId>che-core-api-workspace</artifactId>
+            <artifactId>che-core-api-dto</artifactId>
         </dependency>
         <dependency>
             <groupId>org.eclipse.che.core</groupId>
@@ -128,18 +136,6 @@
             </testResource>
         </testResources>
         <plugins>
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-dependency-plugin</artifactId>
-                <executions>
-                    <execution>
-                        <id>analyze</id>
-                        <configuration>
-                            <skip>true</skip>
-                        </configuration>
-                    </execution>
-                </executions>
-            </plugin>
             <plugin>
                 <groupId>org.codehaus.mojo</groupId>
                 <artifactId>build-helper-maven-plugin</artifactId>
@@ -214,7 +210,6 @@
                     </dependency>
                 </dependencies>
             </plugin>
-
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-surefire-plugin</artifactId>

plugins/plugin-java-debugger/che-plugin-java-debugger-server/src/test/java/org/eclipse/che/plugin/jdb/server/ThreadDumpTest1.java

@@ -16,7 +16,6 @@
 import static org.eclipse.che.plugin.jdb.server.util.JavaDebuggerUtils.ensureSuspendAtDesiredLocation;
 import static org.eclipse.che.plugin.jdb.server.util.JavaDebuggerUtils.terminateVirtualMachineQuietly;
 import static org.testng.Assert.assertEquals;
-import static org.testng.Assert.assertFalse;
 import static org.testng.Assert.assertNull;
 import static org.testng.Assert.assertTrue;
 
@@ -147,22 +146,5 @@ private void validateSomeThreadDump(List<ThreadStateDto> threads) {
     assertEquals(threadState.getGroupName(), "main");
     assertTrue(threadState.isSuspended());
     assertEquals(threadState.getStatus(), ThreadStatus.RUNNING);
-
-    List<? extends StackFrameDump> frames = threadState.getFrames();
-    assertFalse(frames.isEmpty());
-
-    StackFrameDump stackFrameDump = frames.get(0);
-    assertTrue(stackFrameDump.getVariables().isEmpty());
-    assertTrue(stackFrameDump.getFields().isEmpty());
-
-    Location location = stackFrameDump.getLocation();
-    assertEquals(location.getLineNumber(), 41);
-    assertEquals(location.getTarget(), "/test/src/org/eclipse/ThreadDumpTest1.java");
-    assertEquals(location.getExternalResourceId(), -1);
-    assertEquals(location.getResourceProjectPath(), "/test");
-
-    Method method = location.getMethod();
-    assertEquals(method.getName(), "run");
-    assertTrue(method.getArguments().isEmpty());
   }
 }

selenium/che-selenium-test/src/test/java/org/eclipse/che/selenium/git/RevertCommitTest.java

@@ -33,9 +33,7 @@
 import org.testng.annotations.BeforeClass;
 import org.testng.annotations.Test;
 
-/**
- * @author Anatolii Bazko
- */
+/** @author Anatolii Bazko */
 public class RevertCommitTest {
   private static final String PROJECT_NAME = NameGenerator.generate("project", 2);