CHE-6843: Navigate to breakpiont (eclipse-che#6967)

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

Author: tolusha

ide/che-core-ide-api/src/main/java/org/eclipse/che/ide/api/debug/HasLocation.java

@@ -0,0 +1,22 @@
+/*
+ * Copyright (c) 2012-2017 Red Hat, Inc.
+ * All rights reserved. This program and the accompanying materials
+ * are made available under the terms of the Eclipse Public License v1.0
+ * which accompanies this distribution, and is available at
+ * http://www.eclipse.org/legal/epl-v10.html
+ *
+ * Contributors:
+ *   Red Hat, Inc. - initial API and implementation
+ */
+package org.eclipse.che.ide.api.debug;
+
+import org.eclipse.che.api.debug.shared.model.Location;
+
+/**
+ * Marker to indicate that given implementation can deal with debug {@link Location}.
+ *
+ * @author Anatolii Bazko
+ */
+public interface HasLocation {
+  Location toLocation(int lineNumber);
+}

ide/che-core-ide-api/src/main/java/org/eclipse/che/ide/api/resources/File.java

@@ -12,6 +12,7 @@
 
 import com.google.common.annotations.Beta;
 import org.eclipse.che.api.promises.client.Promise;
+import org.eclipse.che.ide.api.debug.HasLocation;
 import org.eclipse.che.ide.api.vcs.HasVcsStatus;
 import org.eclipse.che.ide.resource.Path;
 
@@ -32,7 +33,8 @@
  * @since 4.4.0
  */
 @Beta
-public interface File extends Resource, VirtualFile, ModificationTracker, HasVcsStatus {
+public interface File
+    extends Resource, VirtualFile, ModificationTracker, HasVcsStatus, HasLocation {
 
   /** @see VirtualFile#getDisplayName() */
   @Override

ide/che-core-ide-app/src/main/java/org/eclipse/che/ide/debug/BreakpointManagerImpl.java

@@ -34,6 +34,7 @@
 import org.eclipse.che.ide.api.debug.BreakpointRenderer.LineChangeAction;
 import org.eclipse.che.ide.api.debug.BreakpointStorage;
 import org.eclipse.che.ide.api.debug.HasBreakpointRenderer;
+import org.eclipse.che.ide.api.debug.HasLocation;
 import org.eclipse.che.ide.api.editor.EditorAgent;
 import org.eclipse.che.ide.api.editor.EditorOpenedEvent;
 import org.eclipse.che.ide.api.editor.EditorPartPresenter;
@@ -47,7 +48,6 @@
 import org.eclipse.che.ide.api.resources.ResourceChangedEvent;
 import org.eclipse.che.ide.api.resources.ResourceDelta;
 import org.eclipse.che.ide.api.resources.VirtualFile;
-import org.eclipse.che.ide.project.node.SyntheticNode;
 import org.eclipse.che.ide.resource.Path;
 
 /**
@@ -102,22 +102,13 @@ public void changeBreakpointState(final int lineNumber) {
     if (existedBreakpoint.isPresent()) {
       deleteBreakpoint(activeFile, existedBreakpoint.get());
     } else {
-      String project = null;
-      if (activeFile instanceof SyntheticNode) {
-        project = ((SyntheticNode) activeFile).getProject().toString();
-      } else if (activeFile instanceof Resource) {
-        project = ((Resource) activeFile).getProject().getPath();
-      }
-
-      if (project == null) {
-        LOG.warning("Impossible to figure out project for: " + activeFile.getLocation().toString());
+      if (activeFile instanceof HasLocation) {
+        addBreakpoint(
+            activeFile, new BreakpointImpl(((HasLocation) activeFile).toLocation(lineNumber + 1)));
+      } else {
+        LOG.warning("Impossible to figure debug location for: " + activeFile.getLocation());
         return;
       }
-
-      addBreakpoint(
-          activeFile,
-          new BreakpointImpl(
-              new LocationImpl(activeFile.getLocation().toString(), lineNumber + 1, project)));
     }
   }
 

ide/che-core-ide-app/src/main/java/org/eclipse/che/ide/resources/impl/FileImpl.java

@@ -15,6 +15,8 @@
 import com.google.common.base.Optional;
 import com.google.inject.Inject;
 import com.google.inject.assistedinject.Assisted;
+import org.eclipse.che.api.debug.shared.model.Location;
+import org.eclipse.che.api.debug.shared.model.impl.LocationImpl;
 import org.eclipse.che.api.promises.client.Promise;
 import org.eclipse.che.ide.api.resources.File;
 import org.eclipse.che.ide.api.resources.marker.Marker;
@@ -159,4 +161,9 @@ public VcsStatus getVcsStatus() {
   public void setVcsStatus(VcsStatus vcsStatus) {
     this.vcsStatus = vcsStatus;
   }
+
+  @Override
+  public Location toLocation(int lineNumber) {
+    return new LocationImpl(getLocation().toString(), lineNumber, getProject().getPath());
+  }
 }

plugins/plugin-debugger/che-plugin-debugger-ide/src/main/java/org/eclipse/che/plugin/debugger/ide/debug/AbstractDebugger.java

@@ -98,7 +98,7 @@ public abstract class AbstractDebugger implements Debugger, DebuggerObservable {
   private final DebuggerServiceClient service;
   private final LocalStorageProvider localStorageProvider;
   private final EventBus eventBus;
-  private final DebuggerResourceHandlerFactory debuggerResourceHandlerFactory;
+  private final DebuggerLocationHandlerManager debuggerLocationHandlerManager;
   private final DebuggerManager debuggerManager;
   private final BreakpointManager breakpointManager;
   private final String debuggerType;
@@ -118,15 +118,15 @@ public AbstractDebugger(
       NotificationManager notificationManager,
       BreakpointManager breakpointManager,
       RequestHandlerManager requestHandlerManager,
-      DebuggerResourceHandlerFactory debuggerResourceHandlerFactory,
+      DebuggerLocationHandlerManager debuggerLocationHandlerManager,
       String type) {
     this.service = service;
     this.transmitter = transmitter;
     this.configurator = configurator;
     this.dtoFactory = dtoFactory;
     this.localStorageProvider = localStorageProvider;
     this.eventBus = eventBus;
-    this.debuggerResourceHandlerFactory = debuggerResourceHandlerFactory;
+    this.debuggerLocationHandlerManager = debuggerLocationHandlerManager;
     this.debuggerManager = debuggerManager;
     this.notificationManager = notificationManager;
     this.breakpointManager = breakpointManager;
@@ -170,8 +170,8 @@ public void onWsAgentStarted(WsAgentStateEvent event) {
                       }
 
                       if (currentLocation != null) {
-                        debuggerResourceHandlerFactory
-                            .getOrDefault(getDebuggerType())
+                        debuggerLocationHandlerManager
+                            .getOrDefault(currentLocation)
                             .find(
                                 currentLocation,
                                 new AsyncCallback<VirtualFile>() {
@@ -230,8 +230,8 @@ private void onEventListReceived(@NotNull DebuggerEventDto event) {
   }
 
   private void open(Location location) {
-    debuggerResourceHandlerFactory
-        .getOrDefault(getDebuggerType())
+    debuggerLocationHandlerManager
+        .getOrDefault(location)
         .open(
             location,
             new AsyncCallback<VirtualFile>() {

…r/ide/debug/DebuggerResourceHandler.java …r/ide/debug/DebuggerLocationHandler.javaplugins/plugin-debugger/che-plugin-debugger-ide/src/main/java/org/eclipse/che/plugin/debugger/ide/debug/DebuggerResourceHandler.java renamed to plugins/plugin-debugger/che-plugin-debugger-ide/src/main/java/org/eclipse/che/plugin/debugger/ide/debug/DebuggerLocationHandler.java plugins/plugin-debugger/che-plugin-debugger-ide/src/main/java/org/eclipse/che/plugin/debugger/ide/debug/DebuggerResourceHandler.java renamed to plugins/plugin-debugger/che-plugin-debugger-ide/src/main/java/org/eclipse/che/plugin/debugger/ide/debug/DebuggerLocationHandler.java

@@ -21,7 +21,10 @@
  * @see Location#getLineNumber()
  * @author Anatoliy Bazko
  */
-public interface DebuggerResourceHandler {
+public interface DebuggerLocationHandler {
+
+  /** Indicates if handler can deal with the given location. */
+  boolean isSuitedFor(Location location);
 
   /**
    * Opens resource is being debugged and scrolls to the position {@link Location#getLineNumber()}.

plugins/plugin-debugger/che-plugin-debugger-ide/src/main/java/org/eclipse/che/plugin/debugger/ide/debug/DebuggerLocationHandlerManager.java

@@ -0,0 +1,45 @@
+/*
+ * Copyright (c) 2012-2017 Red Hat, Inc.
+ * All rights reserved. This program and the accompanying materials
+ * are made available under the terms of the Eclipse Public License v1.0
+ * which accompanies this distribution, and is available at
+ * http://www.eclipse.org/legal/epl-v10.html
+ *
+ * Contributors:
+ *   Red Hat, Inc. - initial API and implementation
+ */
+package org.eclipse.che.plugin.debugger.ide.debug;
+
+import com.google.inject.Inject;
+import com.google.inject.Singleton;
+import java.util.HashSet;
+import java.util.Set;
+import org.eclipse.che.api.debug.shared.model.Location;
+
+/** @author Anatolii Bazko */
+@Singleton
+public class DebuggerLocationHandlerManager {
+
+  private final Set<DebuggerLocationHandler> handlers;
+  private final DebuggerLocationHandler defaultHandler;
+
+  @Inject
+  public DebuggerLocationHandlerManager(FileResourceLocationHandler defaultHandler) {
+    this.handlers = new HashSet<>();
+    this.defaultHandler = defaultHandler;
+  }
+
+  /** Returns handler for the given location. */
+  public DebuggerLocationHandler getOrDefault(Location location) {
+    for (DebuggerLocationHandler handler : handlers) {
+      if (handler.isSuitedFor(location)) {
+        return handler;
+      }
+    }
+    return defaultHandler;
+  }
+
+  public void register(DebuggerLocationHandler handler) {
+    handlers.add(handler);
+  }
+}

plugins/plugin-debugger/che-plugin-debugger-ide/src/main/java/org/eclipse/che/plugin/debugger/ide/debug/DebuggerPresenter.java

@@ -82,7 +82,7 @@ public class DebuggerPresenter extends BasePresenter
   private final DebuggerView view;
   private final DebuggerManager debuggerManager;
   private final WorkspaceAgent workspaceAgent;
-  private final DebuggerResourceHandlerFactory resourceHandlerManager;
+  private final DebuggerLocationHandlerManager locationHandlerManager;
   private final BreakpointContextMenuFactory breakpointContextMenuFactory;
 
   private List<Variable> variables;
@@ -102,15 +102,15 @@ public DebuggerPresenter(
       final @DebuggerWatchToolBar ToolbarPresenter watchToolbar,
       final DebuggerManager debuggerManager,
       final WorkspaceAgent workspaceAgent,
-      final DebuggerResourceHandlerFactory resourceHandlerManager,
+      final DebuggerLocationHandlerManager locationHandlerManager,
       final BreakpointContextMenuFactory breakpointContextMenuFactory) {
     this.view = view;
     this.debuggerResources = debuggerResources;
     this.debuggerToolbar = debuggerToolbar;
     this.watchToolbar = watchToolbar;
     this.debuggerManager = debuggerManager;
     this.workspaceAgent = workspaceAgent;
-    this.resourceHandlerManager = resourceHandlerManager;
+    this.locationHandlerManager = locationHandlerManager;
     this.view.setDelegate(this);
     this.view.setTitle(TITLE);
     this.constant = constant;
@@ -203,8 +203,7 @@ public void onSelectedFrame(int frameIndex) {
   protected void open(Location location) {
     Debugger debugger = debuggerManager.getActiveDebugger();
     if (debugger != null) {
-      DebuggerResourceHandler handler =
-          resourceHandlerManager.getOrDefault(debugger.getDebuggerType());
+      DebuggerLocationHandler handler = locationHandlerManager.getOrDefault(location);
 
       handler.open(
           location,
@@ -527,4 +526,20 @@ public void onBreakpointContextMenu(int clientX, int clientY, Breakpoint breakpo
         .scheduleDeferred(
             () -> breakpointContextMenuFactory.newContextMenu(breakpoint).show(clientX, clientY));
   }
+
+  @Override
+  public void onBreakpointDoubleClick(Breakpoint breakpoint) {
+    Location location = breakpoint.getLocation();
+    locationHandlerManager
+        .getOrDefault(location)
+        .open(
+            location,
+            new AsyncCallback<VirtualFile>() {
+              @Override
+              public void onFailure(Throwable caught) {}
+
+              @Override
+              public void onSuccess(VirtualFile result) {}
+            });
+  }
 }

plugins/plugin-debugger/che-plugin-debugger-ide/src/main/java/org/eclipse/che/plugin/debugger/ide/debug/DebuggerResourceHandlerFactory.java

@@ -49,6 +49,8 @@ interface ActionDelegate extends BaseActionDelegate {
     /** Breakpoint context menu is invoked. */
     void onBreakpointContextMenu(int clientX, int clientY, Breakpoint breakpoint);
 
+    void onBreakpointDoubleClick(Breakpoint breakpoint);
+
     /**
      * Performs any actions appropriate in response to the user having pressed the expand button in
      * variables tree.