Skip to content

Commit 7ce87d9

Browse files
authored
Fix project path in some test related to Factory feature (eclipse-che#6418)
* Fix project path in some test related to Factory feature Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
1 parent 62fc174 commit 7ce87d9

4 files changed

Lines changed: 11 additions & 15 deletions

File tree

selenium/che-selenium-test/src/test/java/org/eclipse/che/selenium/factory/CheckFactoryWithMultiModuleTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public void setUp() throws Exception {
5151
testFactoryInitializer.fromTemplate(FactoryTemplate.MINIMAL);
5252
ProjectConfigDto projectConfigDto = factoryBuilder.getWorkspace().getProjects().get(0);
5353
projectConfigDto.setName(PROJECT_NAME);
54-
projectConfigDto.setPath(PROJECT_NAME);
54+
projectConfigDto.setPath("/" + PROJECT_NAME);
5555
projectConfigDto.getSource().setParameters(ImmutableMap.of("branch", "master"));
5656
projectConfigDto
5757
.getSource()

selenium/che-selenium-test/src/test/java/org/eclipse/che/selenium/factory/CheckFactoryWithPerUserCreatePolicyTest.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
import org.eclipse.che.selenium.core.factory.FactoryTemplate;
2020
import org.eclipse.che.selenium.core.factory.TestFactory;
2121
import org.eclipse.che.selenium.core.factory.TestFactoryInitializer;
22-
import org.eclipse.che.selenium.pageobject.Ide;
2322
import org.eclipse.che.selenium.pageobject.NotificationsPopupPanel;
2423
import org.eclipse.che.selenium.pageobject.ProjectExplorer;
2524
import org.eclipse.che.selenium.pageobject.dashboard.Dashboard;
@@ -29,7 +28,6 @@
2928

3029
/** @author Mihail Kuznyetsov */
3130
public class CheckFactoryWithPerUserCreatePolicyTest {
32-
@Inject private Ide ide;
3331
@Inject private ProjectExplorer projectExplorer;
3432
@Inject private Dashboard dashboard;
3533
@Inject private NotificationsPopupPanel notificationsPopupPanel;
@@ -56,21 +54,21 @@ public void checkFactoryAcceptingWithPerUserPolicy() throws Exception {
5654
dashboard.open();
5755

5856
// accept factory
59-
testFactory.open(ide.driver());
57+
testFactory.open(seleniumWebDriver);
6058

6159
seleniumWebDriver.switchFromDashboardIframeToIde();
6260
projectExplorer.waitProjectExplorer();
6361
notificationsPopupPanel.waitExpectedMessageOnProgressPanelAndClosed("Project Spring imported");
6462

65-
String workspaceUrl = ide.driver().getCurrentUrl();
63+
String workspaceUrl = seleniumWebDriver.getCurrentUrl();
6664

6765
// accept factory
68-
testFactory.open(ide.driver());
66+
testFactory.open(seleniumWebDriver);
6967

7068
seleniumWebDriver.switchFromDashboardIframeToIde();
7169
projectExplorer.waitProjectExplorer();
7270

7371
// factory has been accepted in the same workspace
74-
assertEquals(workspaceUrl, ide.driver().getCurrentUrl());
72+
assertEquals(workspaceUrl, seleniumWebDriver.getCurrentUrl());
7573
}
7674
}

selenium/che-selenium-test/src/test/java/org/eclipse/che/selenium/factory/CheckFactoryWithSparseCheckoutTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public void setUp() throws Exception {
5252
.getSource()
5353
.setLocation("https://github.com/" + gitHubUsername + "/" + PROJECT_NAME);
5454
projectConfig.setName(PROJECT_NAME);
55-
projectConfig.setPath(PROJECT_NAME);
55+
projectConfig.setPath("/" + PROJECT_NAME);
5656
testFactory = testFactoryBuilder.build();
5757
}
5858

selenium/che-selenium-test/src/test/java/org/eclipse/che/selenium/factory/CheckFactoryWithUntilPolicyTest.java

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
import org.eclipse.che.selenium.core.factory.TestFactory;
2424
import org.eclipse.che.selenium.core.factory.TestFactoryInitializer;
2525
import org.eclipse.che.selenium.core.utils.WaitUtils;
26-
import org.eclipse.che.selenium.pageobject.Ide;
2726
import org.eclipse.che.selenium.pageobject.PopupDialogsBrowser;
2827
import org.eclipse.che.selenium.pageobject.ProjectExplorer;
2928
import org.eclipse.che.selenium.pageobject.dashboard.Dashboard;
@@ -43,7 +42,6 @@ public class CheckFactoryWithUntilPolicyTest {
4342

4443
@Inject private ProjectExplorer projectExplorer;
4544
@Inject private TestFactoryInitializer testFactoryInitializer;
46-
@Inject private Ide ide;
4745
@Inject private PopupDialogsBrowser popupDialogsBrowser;
4846
@Inject private Dashboard dashboard;
4947
@Inject private SeleniumWebDriver seleniumWebDriver;
@@ -69,7 +67,7 @@ public void tearDown() throws Exception {
6967
public void checkFactoryAcceptingWithUntilPolicy() throws Exception {
7068
// first
7169
dashboard.open();
72-
testFactory.open(ide.driver());
70+
testFactory.open(seleniumWebDriver);
7371
seleniumWebDriver.switchFromDashboardIframeToIde();
7472
projectExplorer.waitProjectExplorer();
7573
while (System.currentTimeMillis() <= INIT_TIME + ADDITIONAL_TIME) {
@@ -81,12 +79,12 @@ public void checkFactoryAcceptingWithUntilPolicy() throws Exception {
8179
}
8280

8381
// second
84-
testFactory.open(ide.driver());
85-
new WebDriverWait(ide.driver(), PREPARING_WS_TIMEOUT_SEC)
82+
testFactory.open(seleniumWebDriver);
83+
new WebDriverWait(seleniumWebDriver, PREPARING_WS_TIMEOUT_SEC)
8684
.until(ExpectedConditions.alertIsPresent());
8785
assertTrue(
88-
ide.driver().switchTo().alert().getText().contains(ALERT_EXPIRE_MESSAGE),
89-
"actual message: " + ide.driver().switchTo().alert().getText());
86+
seleniumWebDriver.switchTo().alert().getText().contains(ALERT_EXPIRE_MESSAGE),
87+
"actual message: " + seleniumWebDriver.switchTo().alert().getText());
9088
popupDialogsBrowser.acceptAlert();
9189
}
9290
}

0 commit comments

Comments
 (0)