Skip to content

Commit 861f4ec

Browse files
committed
CHE-6463 Remove machine auth code that is outdated in spi
1 parent 92c5d1a commit 861f4ec

15 files changed

Lines changed: 10 additions & 588 deletions

File tree

assembly-multiuser/assembly-wsmaster-war/pom.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -103,10 +103,10 @@
103103
<groupId>org.eclipse.che.plugin</groupId>
104104
<artifactId>che-plugin-activity-wsmaster</artifactId>
105105
</dependency>
106-
<dependency>
107-
<groupId>org.eclipse.che.plugin</groupId>
108-
<artifactId>che-plugin-docker-machine-auth</artifactId>
109-
</dependency>
106+
<!--<dependency>-->
107+
<!--<groupId>org.eclipse.che.plugin</groupId>-->
108+
<!--<artifactId>che-plugin-docker-machine-auth</artifactId>-->
109+
<!--</dependency>-->
110110
<dependency>
111111
<groupId>org.postgresql</groupId>
112112
<artifactId>postgresql</artifactId>

assembly/assembly-wsmaster-war/src/main/java/org/eclipse/che/api/deploy/CheWsMasterModule.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,6 @@ protected void configure() {
2727

2828
bind(TokenValidator.class).to(org.eclipse.che.api.local.DummyTokenValidator.class);
2929

30-
bind(org.eclipse.che.api.agent.server.WsAgentHealthChecker.class)
31-
.to(org.eclipse.che.api.agent.server.WsAgentHealthCheckerImpl.class);
32-
33-
bind(org.eclipse.che.api.environment.server.MachineInstanceProvider.class)
34-
.to(org.eclipse.che.plugin.docker.machine.MachineProviderImpl.class);
35-
3630
bind(org.eclipse.che.api.workspace.server.stack.StackLoader.class);
3731
bind(DataSource.class).toProvider(org.eclipse.che.core.db.h2.H2DataSourceProvider.class);
3832

multiuser/keycloak/che-multiuser-keycloak-ide/src/main/java/org/eclipse/che/multiuser/keycloak/ide/KeycloakProvider.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public class KeycloakProvider {
4040
public KeycloakProvider(AppContext appContext, PromiseProvider promiseProvider) {
4141
this.appContext = appContext;
4242
String keycloakSettings =
43-
getKeycloakSettings(KeycloakConstants.getEndpoint(appContext.getMasterEndpoint()));
43+
getKeycloakSettings(KeycloakConstants.getEndpoint(appContext.getMasterApiEndpoint()));
4444
Map<String, String> settings = JsonHelper.toMap(keycloakSettings);
4545
Log.info(getClass(), "Keycloak settings: ", settings);
4646

multiuser/machine-auth/che-multiuser-machine-authentication-ide/pom.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,6 @@
4141
<groupId>javax.annotation</groupId>
4242
<artifactId>javax.annotation-api</artifactId>
4343
</dependency>
44-
<dependency>
45-
<groupId>org.eclipse.che.core</groupId>
46-
<artifactId>che-core-api-core</artifactId>
47-
</dependency>
4844
<dependency>
4945
<groupId>org.eclipse.che.core</groupId>
5046
<artifactId>che-core-api-dto</artifactId>

multiuser/machine-auth/che-multiuser-machine-authentication-ide/src/main/java/org/eclipse/che/multiuser/machine/authentication/ide/CheAuthMachineLinksModifier.java

Lines changed: 0 additions & 51 deletions
This file was deleted.

multiuser/machine-auth/che-multiuser-machine-authentication-ide/src/main/java/org/eclipse/che/multiuser/machine/authentication/ide/MachineAsyncRequestFactory.java

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
import org.eclipse.che.api.promises.client.Promise;
2626
import org.eclipse.che.api.promises.client.js.Promises;
2727
import org.eclipse.che.ide.api.app.AppContext;
28-
import org.eclipse.che.ide.api.machine.DevMachine;
2928
import org.eclipse.che.ide.api.workspace.event.WorkspaceStoppedEvent;
3029
import org.eclipse.che.ide.commons.exception.UnmarshallerException;
3130
import org.eclipse.che.ide.dto.DtoFactory;
@@ -49,7 +48,6 @@ public class MachineAsyncRequestFactory extends AsyncRequestFactory
4948
private final AppContext appContext;
5049

5150
private String machineToken;
52-
private String wsAgentBaseUrl;
5351
private String csrfToken;
5452

5553
@Inject
@@ -101,7 +99,6 @@ private Promise<String> getMachineToken() {
10199
@Override
102100
public void onWorkspaceStopped(WorkspaceStoppedEvent event) {
103101
machineToken = null;
104-
wsAgentBaseUrl = null;
105102
}
106103

107104
/**
@@ -115,22 +112,14 @@ protected boolean isWsAgentRequest(String url) {
115112
|| !RUNNING.equals(appContext.getWorkspace().getStatus())) {
116113
return false; //ws-agent not started
117114
}
118-
if (isNullOrEmpty(wsAgentBaseUrl)) {
119-
final DevMachine devMachine = appContext.getDevMachine();
120-
if (devMachine != null) {
121-
wsAgentBaseUrl = devMachine.getWsAgentBaseUrl();
122-
} else {
123-
return false;
124-
}
125-
}
126-
return url.contains(nullToEmpty(wsAgentBaseUrl));
115+
return url.contains(nullToEmpty(appContext.getWsAgentServerApiEndpoint()));
127116
}
128117

129118
private Promise<String> requestCsrfToken() {
130119
if (csrfToken != null) {
131120
return Promises.resolve(csrfToken);
132121
}
133-
return createGetRequest(appContext.getMasterEndpoint() + "/profile")
122+
return createGetRequest(appContext.getMasterApiEndpoint() + "/profile")
134123
.header(CSRF_TOKEN_HEADER_NAME, "Fetch")
135124
.send(
136125
new Unmarshallable<String>() {

multiuser/machine-auth/che-multiuser-machine-authentication-ide/src/main/java/org/eclipse/che/multiuser/machine/authentication/ide/MachineTokenServiceClientImpl.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
import org.eclipse.che.ide.api.app.AppContext;
1717
import org.eclipse.che.ide.rest.AsyncRequestFactory;
1818
import org.eclipse.che.ide.rest.DtoUnmarshallerFactory;
19-
import org.eclipse.che.ide.rest.RestContext;
2019
import org.eclipse.che.multiuser.machine.authentication.shared.dto.MachineTokenDto;
2120

2221
/**
@@ -34,14 +33,13 @@ public class MachineTokenServiceClientImpl implements MachineTokenServiceClient
3433

3534
@Inject
3635
public MachineTokenServiceClientImpl(
37-
@RestContext String restContext,
3836
AppContext appContext,
3937
AsyncRequestFactory asyncRequestFactory,
4038
DtoUnmarshallerFactory dtoUnmarshallerFactory) {
4139
this.appContext = appContext;
4240
this.asyncRequestFactory = asyncRequestFactory;
4341
this.dtoUnmarshallerFactory = dtoUnmarshallerFactory;
44-
this.baseUrl = restContext + MACHINE_TOKEN_SERVICE_PATH;
42+
this.baseUrl = appContext.getMasterApiEndpoint() + MACHINE_TOKEN_SERVICE_PATH;
4543
}
4644

4745
public Promise<MachineTokenDto> getMachineToken() {

multiuser/machine-auth/che-multiuser-machine-authentication-ide/src/main/java/org/eclipse/che/multiuser/machine/authentication/ide/inject/MachineAuthGinModule.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@
1313
import com.google.gwt.inject.client.AbstractGinModule;
1414
import com.google.inject.Singleton;
1515
import org.eclipse.che.ide.api.extension.ExtensionGinModule;
16-
import org.eclipse.che.ide.api.machine.CheWsAgentLinksModifier;
17-
import org.eclipse.che.multiuser.machine.authentication.ide.CheAuthMachineLinksModifier;
1816
import org.eclipse.che.multiuser.machine.authentication.ide.MachineTokenServiceClient;
1917
import org.eclipse.che.multiuser.machine.authentication.ide.MachineTokenServiceClientImpl;
2018

@@ -24,10 +22,8 @@ public class MachineAuthGinModule extends AbstractGinModule {
2422

2523
@Override
2624
protected void configure() {
27-
//bind(AsyncRequestFactory.class).to(MachineAsyncRequestFactory.class);
2825
bind(MachineTokenServiceClient.class)
2926
.to(MachineTokenServiceClientImpl.class)
3027
.in(Singleton.class);
31-
bind(CheWsAgentLinksModifier.class).to(CheAuthMachineLinksModifier.class);
3228
}
3329
}

multiuser/machine-auth/che-multiuser-machine-authentication/pom.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -113,10 +113,6 @@
113113
<groupId>org.everrest</groupId>
114114
<artifactId>everrest-core</artifactId>
115115
</dependency>
116-
<dependency>
117-
<groupId>org.slf4j</groupId>
118-
<artifactId>slf4j-api</artifactId>
119-
</dependency>
120116
<dependency>
121117
<groupId>org.eclipse.che.multiuser</groupId>
122118
<artifactId>che-multiuser-api-permission</artifactId>

multiuser/machine-auth/che-multiuser-machine-authentication/src/main/java/org/eclipse/che/multiuser/machine/authentication/server/AuthWsAgentHealthChecker.java

Lines changed: 0 additions & 67 deletions
This file was deleted.

0 commit comments

Comments
 (0)