Stabilizing the tests in in "intelligencecommand", "autocomplete", "projectexplorer" packages (eclipse-che#6949)

Author: Ohrimenko1988

selenium/che-selenium-test/src/main/java/org/eclipse/che/selenium/pageobject/FindText.java

@@ -61,6 +61,7 @@ private interface Locators {
     String CANCEL_BUTTON = "search-cancel-button";
     String SEARCH_BUTTON = "search-button";
     String FIND_INFO_PANEL = "gwt-debug-find-info-panel";
+    String FIND_INFO_PANEL_TEXT_CONTAINER = "gwt-debug-partStackContent";
     String FIND_TEXT_BUTTON = "gwt-debug-partButton-Find";
     String OCCURRENCE = "//span[@debugfilepath = '%s']";
   }
@@ -77,6 +78,9 @@ private interface Locators {
   @FindBy(id = Locators.FIND_INFO_PANEL)
   WebElement findInfoPanel;
 
+  @FindBy(id = Locators.FIND_INFO_PANEL_TEXT_CONTAINER)
+  WebElement findInfoPanelTextContainer;
+
   @FindBy(id = Locators.FIND_TEXT_BUTTON)
   WebElement findTextBtn;
 
@@ -351,7 +355,7 @@ public void waitTextIntoFileNameFilter(String expText) {
   /** wait the 'Find' info panel is open */
   public void waitFindInfoPanelIsOpen() {
     new WebDriverWait(seleniumWebDriver, REDRAW_UI_ELEMENTS_TIMEOUT_SEC)
-        .until(ExpectedConditions.visibilityOfElementLocated(By.id(Locators.FIND_INFO_PANEL)));
+        .until(ExpectedConditions.visibilityOf(findInfoPanel));
   }
 
   /** wait the 'Find' info panel is closed */
@@ -414,7 +418,7 @@ public void waitExpectedTextIsNotPresentInFindInfoPanel(String expText) {
    * @return text from 'find usages' panel
    */
   public String getTextFromFindInfoPanel() {
-    return findInfoPanel.getText();
+    return findInfoPanelTextContainer.getText();
   }
 
   public void selectItemInFindInfoPanel(String fileName, String textToFind) {

selenium/che-selenium-test/src/main/java/org/eclipse/che/selenium/pageobject/ProjectExplorer.java

@@ -562,8 +562,10 @@ public void clickOnItemInContextMenu(String item) {
    * @param item item form {@code SubMenuNew}
    */
   public void clickOnNewContextMenuItem(String item) {
-    WebElement menuItem = seleniumWebDriver.findElement(By.id(item));
-    menuItem.click();
+    new WebDriverWait(seleniumWebDriver, 10)
+        .until(ExpectedConditions.visibilityOf(seleniumWebDriver.findElement(By.id(item))))
+        .click();
+
     waitContextMenuPopUpClosed();
   }
 

selenium/che-selenium-test/src/test/java/org/eclipse/che/selenium/editor/autocomplete/AutocompleteProposalJavaDocTest.java

@@ -67,6 +67,7 @@ public void setup() throws Exception {
     ide.open(workspace);
     loader.waitOnClosed();
     projectExplorer.waitItem(PROJECT);
+    projectExplorer.selectItem(PROJECT);
     notificationsPopupPanel.waitProgressPopupPanelClose();
 
     projectExplorer.quickExpandWithJavaScript();

selenium/che-selenium-test/src/test/java/org/eclipse/che/selenium/editor/autocomplete/AutocompleteWithInheritTest.java

@@ -68,11 +68,15 @@ public void prepare() throws Exception {
   @Test
   public void updateDependencyWithInheritTest() {
     projectExplorer.waitProjectExplorer();
-    // projectExplorer.waitItem(PROJECT_NAME);
+    projectExplorer.waitItem(PROJECT_NAME);
     mavenPluginStatusBar.waitClosingInfoPanel();
+
+    projectExplorer.selectItem(PROJECT_NAME);
     projectExplorer.quickExpandWithJavaScript();
+
     projectExplorer.openItemByVisibleNameInExplorer("AppController.java");
     editor.waitAllMarkersDisappear(ERROR_MARKER);
+
     projectExplorer.openItemByVisibleNameInExplorer(EXTENDED_CLASS + ".java");
     editor.returnFocusInCurrentLine();
     editor.waitMarkerInPosition(ERROR_MARKER, 13);

selenium/che-selenium-test/src/test/java/org/eclipse/che/selenium/editor/autocomplete/InheritClassTest.java

@@ -70,6 +70,7 @@ public void autoCompleteClassInTheSamePackage() {
     projectExplorer.waitItem(PROJECT_NAME);
     notificationsPopupPanel.waitProgressPopupPanelClose();
     loader.waitOnClosed();
+    projectExplorer.selectItem(PROJECT_NAME);
     projectExplorer.quickExpandWithJavaScript();
     loader.waitOnClosed();
     projectExplorer.openItemByPath(COMMON_PACKAGE + "/AppController.java");

selenium/che-selenium-test/src/test/java/org/eclipse/che/selenium/projectexplorer/CheckOnValidAndInvalidClassNameTest.java

@@ -88,7 +88,9 @@ public void shouldNotCreateClassWithInvalidNameInRootPackage(String className) {
 
   private void createJavaClassByPath(String classPath, String className) {
     projectExplorer.openContextMenuByPathSelectedItem(classPath);
+    projectExplorer.waitContextMenu();
     projectExplorer.clickOnItemInContextMenu(TestProjectExplorerContextMenuConstants.NEW);
+    projectExplorer.waitContextMenu();
     projectExplorer.clickOnNewContextMenuItem(
         TestProjectExplorerContextMenuConstants.SubMenuNew.JAVA_CLASS);
     askForValueDialog.waitNewJavaClassOpen();
@@ -99,7 +101,9 @@ private void createJavaClassByPath(String classPath, String className) {
 
   private void tryToCreateJavaClassWithNotValidNameByPath(String elementPath, String className) {
     projectExplorer.openContextMenuByPathSelectedItem(elementPath);
+    projectExplorer.waitContextMenu();
     projectExplorer.clickOnItemInContextMenu(TestProjectExplorerContextMenuConstants.NEW);
+    projectExplorer.waitContextMenu();
     projectExplorer.clickOnNewContextMenuItem(
         TestProjectExplorerContextMenuConstants.SubMenuNew.JAVA_CLASS);
     askForValueDialog.waitNewJavaClassOpen();

selenium/che-selenium-test/src/test/java/org/eclipse/che/selenium/projectexplorer/CheckOnValidAndInvalidPackageNameTest.java

@@ -114,7 +114,9 @@ public void createInvalidPackageNameInRootPackageTest(String packageName) {
 
   private void createPackageByPath(String packagePath, String packageName) {
     projectExplorer.openContextMenuByPathSelectedItem(packagePath);
+    projectExplorer.waitContextMenu();
     projectExplorer.clickOnItemInContextMenu(TestProjectExplorerContextMenuConstants.NEW);
+    projectExplorer.waitContextMenu();
     projectExplorer.clickOnNewContextMenuItem(
         TestProjectExplorerContextMenuConstants.SubMenuNew.JAVA_PACKAGE);
     askForValueDialog.waitFormToOpen();

selenium/che-selenium-test/src/test/java/org/eclipse/che/selenium/projectexplorer/NavigationByKeyboardTest.java

@@ -88,6 +88,7 @@ public void setUp() throws Exception {
 
   @Test
   public void navigationByKeyboard() throws Exception {
+    projectExplorer.waitProjectExplorer();
     projectExplorer.waitItem(PROJECT_NAME);
     projectExplorer.openItemByPath(PROJECT_NAME);
     notificationsPopupPanel.waitProgressPopupPanelClose();