code cleanup

Signed-off-by: Oleksii Orel <oorel@redhat.com>

Author: olexii4

dashboard/src/app/admin/plugins/plugins.controller.ts

@@ -50,10 +50,9 @@ export class AdminPluginsCtrl {
     promise.then(() => {
         this.updateData();
         this.isLoading = false;
-      },
-      (error) => {
+      }, (error: any) => {
         this.isLoading = false;
-        if (error.status === 304) {
+        if (error && error.status === 304) {
           this.updateData();
         }
       });

dashboard/src/app/stacks/stack-details/stack.controller.ts

@@ -197,7 +197,7 @@ export class StackController {
       this.loading = false;
       this.prepareStackData();
     }, (error: any) => {
-      if (error.status === 304) {
+      if (error && error.status === 304) {
         this.loading = false;
         this.stack = this.cheStack.getStackById(this.stackId);
         this.prepareStackData();

dashboard/src/app/workspaces/list-workspaces/list-workspaces.controller.ts

@@ -127,7 +127,7 @@ export class ListWorkspacesCtrl {
     promise.then(() => {
       return this.updateSharedWorkspaces();
     }, (error: any) => {
-      if (error.status === 304) {
+      if (error && error.status === 304) {
         // ok
         return this.updateSharedWorkspaces();
       }
@@ -232,6 +232,9 @@ export class ListWorkspacesCtrl {
         this.cheListHelper.itemsSelectionStatus[workspaceId] = false;
 
         let workspace = this.cheWorkspace.getWorkspaceById(workspaceId);
+        if (!workspace) {
+          return;
+        }
         workspaceName = workspace.config.name;
         let stoppedStatusPromise = this.cheWorkspace.fetchStatusChange(workspaceId, 'STOPPED');
 

dashboard/src/app/workspaces/workspace-details/workspace-details.service.ts

@@ -215,7 +215,7 @@ export class WorkspaceDetailsService {
       return this.$q.when();
     }
 
-    const initStatus = oldWorkspace.status;
+    const initStatus = oldWorkspace && oldWorkspace.status;
 
     const oldConfig = angular.copy(oldWorkspace.config);
     delete oldConfig.projects;

dashboard/src/components/api/workspace/che-workspace.factory.ts

@@ -312,7 +312,7 @@ export class CheWorkspace {
       });
       return this.workspaces;
     }, (error: any) => {
-      if (error.status === 304) {
+      if (error && error.status === 304) {
         return this.workspaces;
       }
       return this.$q.reject(error);
@@ -354,7 +354,7 @@ export class CheWorkspace {
       this.updateWorkspacesList(workspace);
       defer.resolve();
     }, (error: any) => {
-      if (error.status === 304) {
+      if (error && error.status === 304) {
         defer.resolve();
         return;
       }