CODENVY-170 add promise-based authorization method to OAUth authenticators; prevent project synchronizing when factory used

Signed-off-by: Max Shaposhnik <mshaposhnik@codenvy.com>

Author: Max Shaposhnik

core/ide/che-core-ide-api/src/main/java/org/eclipse/che/ide/api/oauth/OAuth2Authenticator.java

@@ -12,6 +12,7 @@
 
 import com.google.gwt.user.client.rpc.AsyncCallback;
 
+import org.eclipse.che.api.promises.client.Promise;
 import org.eclipse.che.security.oauth.OAuthStatus;
 
 /**
@@ -21,5 +22,7 @@ public interface OAuth2Authenticator {
 
     void authorize(String authenticatorUrl, AsyncCallback<OAuthStatus> callback);
 
+    Promise<OAuthStatus> authorize(String authenticationUrl);
+
     String getProviderName();
 }

core/ide/che-core-ide-app/src/main/java/org/eclipse/che/ide/oauth/DefaultOAuthAuthenticatorImpl.java

@@ -10,9 +10,14 @@
  *******************************************************************************/
 package org.eclipse.che.ide.oauth;
 
+import com.google.gwt.core.client.Callback;
 import com.google.gwt.user.client.rpc.AsyncCallback;
 import com.google.inject.Inject;
 
+import org.eclipse.che.api.promises.client.Promise;
+import org.eclipse.che.api.promises.client.callback.AsyncPromiseHelper;
+import org.eclipse.che.api.promises.client.callback.CallbackPromiseHelper;
+import org.eclipse.che.api.promises.client.js.Promises;
 import org.eclipse.che.ide.CoreLocalizationConstant;
 import org.eclipse.che.ide.api.oauth.OAuth2Authenticator;
 import org.eclipse.che.ide.ui.dialogs.CancelCallback;
@@ -50,6 +55,18 @@ public void authorize(String authenticationUrl, @NotNull final AsyncCallback<OAu
         showDialog();
     }
 
+    public Promise<OAuthStatus> authorize(String authenticationUrl) {
+        this.authenticationUrl = authenticationUrl;
+
+        return AsyncPromiseHelper.createFromAsyncRequest(new AsyncPromiseHelper.RequestCall<OAuthStatus>() {
+            @Override
+            public void makeCall(AsyncCallback<OAuthStatus> callback) {
+                DefaultOAuthAuthenticatorImpl.this.callback = callback;
+                showDialog();
+            }
+        });
+    }
+
     private void showDialog() {
         dialogFactory.createConfirmDialog(localizationConstant.authorizationDialogTitle(), localizationConstant.authorizationDialogText(), new ConfirmCallback() {
             @Override

core/ide/che-core-ide-app/src/main/java/org/eclipse/che/ide/part/explorer/project/synchronize/ProjectConfigSynchronizationListener.java

@@ -101,6 +101,9 @@ public void cancelled() {
 
     @Override
     public void onBeforeExpand(final BeforeExpandNodeEvent event) {
+        if (appContext.getFactory() != null) {
+            return;
+        }
         Node expandedNode = event.getNode();
 
         if (!(expandedNode instanceof ProjectNode)) {

plugins/plugin-github/che-plugin-github-ext-github/src/main/java/org/eclipse/che/ide/ext/github/client/authenticator/GitHubAuthenticatorImpl.java

@@ -17,7 +17,9 @@
 
 import org.eclipse.che.api.promises.client.Operation;
 import org.eclipse.che.api.promises.client.OperationException;
+import org.eclipse.che.api.promises.client.Promise;
 import org.eclipse.che.api.promises.client.PromiseError;
+import org.eclipse.che.api.promises.client.callback.AsyncPromiseHelper;
 import org.eclipse.che.api.ssh.gwt.client.SshServiceClient;
 import org.eclipse.che.api.ssh.shared.dto.SshPairDto;
 import org.eclipse.che.ide.api.app.AppContext;
@@ -86,6 +88,18 @@ public void authorize(String authenticationUrl, @NotNull final AsyncCallback<OAu
         view.showDialog();
     }
 
+    public Promise<OAuthStatus> authorize(String authenticationUrl) {
+        this.authenticationUrl = authenticationUrl;
+
+        return AsyncPromiseHelper.createFromAsyncRequest(new AsyncPromiseHelper.RequestCall<OAuthStatus>() {
+            @Override
+            public void makeCall(AsyncCallback<OAuthStatus> callback) {
+                GitHubAuthenticatorImpl.this.callback = callback;
+                view.showDialog();
+            }
+        });
+    }
+
     @Override
     public String getProviderName() {
         return GITHUB;