Merge pull request eclipse-che#622 from eclipse/CHE-653

Mykola Morhun · Mykola Morhun · commit ea13a4dc30c6 · 2016-03-03T13:03:20.000+02:00
CHE-653: Change value fails with NullPointerException
diff --git a/plugins/plugin-java/che-plugin-java-ext-debugger-java-server/src/main/java/org/eclipse/che/ide/ext/java/jdi/server/Debugger.java b/plugins/plugin-java/che-plugin-java-ext-debugger-java-server/src/main/java/org/eclipse/che/ide/ext/java/jdi/server/Debugger.java
@@ -549,7 +549,10 @@ public void setValue(VariablePath variablePath, String valueExpression) throws D
             if ("static".equals(s)) {
                 continue;
             }
-            if (expression.length() > 0) {
+            // Here we need !s.startsWith("[") condition because
+            // we shouldn't add '.' between arrayName and index of a element
+            // For example we can receive ["arrayName", "[index]"]
+            if (expression.length() > 0 && !s.startsWith("[")) {
                 expression.append('.');
             }
             expression.append(s);

Original file line number	Diff line number	Diff line change
`@@ -549,7 +549,10 @@ public void setValue(VariablePath variablePath, String valueExpression) throws D`
`549`	`549`	`if ("static".equals(s)) {`
`550`	`550`	`continue;`
`551`	`551`	`}`
`552`		`- if (expression.length() > 0) {`
	`552`	`+ // Here we need !s.startsWith("[") condition because`
	`553`	`+ // we shouldn't add '.' between arrayName and index of a element`
	`554`	`+ // For example we can receive ["arrayName", "[index]"]`
	`555`	`+ if (expression.length() > 0 && !s.startsWith("[")) {`
`553`	`556`	`expression.append('.');`
`554`	`557`	`}`
`555`	`558`	`expression.append(s);`