Skip to content

Commit 4bd4e4e

Browse files
committed
missing bits from user page rediscovered
1 parent 28d111d commit 4bd4e4e

3 files changed

Lines changed: 12 additions & 5 deletions

File tree

app/assets/javascripts/discourse/models/user.js

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ Discourse.User = Discourse.Model.extend({
2525
@type {String}
2626
**/
2727
avatarSmall: (function() {
28-
return Discourse.Utilities.avatarUrl(this.get('username'), 'small', this.get('avatar_template'));
28+
return Discourse.Utilities.avatarUrl(this.get('username'), 'small', this.get('avatar_template'));
2929
}).property('username'),
3030

3131
/**
@@ -34,9 +34,13 @@ Discourse.User = Discourse.Model.extend({
3434
@property websiteName
3535
@type {String}
3636
**/
37-
websiteName: (function() {
37+
websiteName: function() {
3838
return this.get('website').split("/")[2];
39-
}).property('website'),
39+
}.property('website'),
40+
41+
hasWebsite: function() {
42+
return this.present('website');
43+
}.property('website'),
4044

4145
/**
4246
Path to this user.
@@ -334,6 +338,7 @@ Discourse.User = Discourse.Model.extend({
334338

335339
onDetailsLoaded: function(callback){
336340
var _this = this;
341+
this.set("loading",false);
337342

338343
if(callback){
339344
this.onDetailsLoadedCallbacks = this.onDetailsLoadedCallbacks || [];
@@ -353,6 +358,7 @@ Discourse.User = Discourse.Model.extend({
353358
**/
354359
loadDetails: function() {
355360

361+
this.set("loading",true);
356362
// Check the preload store first
357363
var user = this;
358364
var username = this.get('username');

app/assets/javascripts/discourse/templates/user/activity.js.handlebars

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
</ul>
2323
<div class='show'>
2424
<dl>
25-
{{#if content.website}}
25+
{{#if content.hasWebsite}}
2626
<dt>{{i18n user.website}}:</dt><dd><a {{bindAttr href="content.website"}} target="_blank">{{content.websiteName}}</a></dd>
2727
{{/if}}
2828
<dt>{{i18n user.created}}:</dt><dd>{{date content.created_at}}</dd>

app/assets/javascripts/discourse/templates/user/user.js.handlebars

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
{{#unless content.loading}}
12
<div class="user-heading">
23
<div class="container">
34
<div class="full-width" id='user-menu'>
@@ -43,4 +44,4 @@
4344
<div class="container">
4445
{{outlet userOutlet}}
4546
</div>
46-
47+
{{/unless}}

0 commit comments

Comments
 (0)