Skip to content

Commit a957a23

Browse files
committed
fixes missing imege url errors in logo component tests
1 parent e9f9d22 commit a957a23

1 file changed

Lines changed: 4 additions & 6 deletions

File tree

test/javascripts/components/logo_component_test.js

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@ var setMinimized = function(value) {
2828
};
2929

3030

31+
var smallLogoUrl = "/assets/logo-single.png";
32+
var bigLogoUrl = "/assets/logo.png";
3133
var smallLogoSelector = "img.logo-small";
3234
var bigLogoSelector = "img#site-logo.logo-big";
3335
var homeIconSelector = "i.icon-home";
@@ -44,10 +46,6 @@ var appendView = function() {
4446
module("Discourse.DiscourseLogoComponent", {
4547
setup: function() {
4648
oldMobileView = Discourse.Mobile.mobileView;
47-
48-
setSmallLogoUrl("small-logo-url");
49-
setBigLogoUrl("big-logo-url");
50-
5149
view = View.create();
5250
},
5351

@@ -63,7 +61,7 @@ test("displays small logo when 'minimized' version is chosen and application is
6361
appendView();
6462

6563
ok(exists(fixture(smallLogoSelector)), "small logo image is present");
66-
equal(fixture(smallLogoSelector).attr("src"), "small-logo-url", "small logo image has correct source");
64+
equal(fixture(smallLogoSelector).attr("src"), smallLogoUrl, "small logo image has correct source");
6765
ok(!exists(fixture(homeIconSelector)), "default home icon is not present");
6866
ok(!exists(fixture(bigLogoSelector)), "big logo image is not present");
6967
});
@@ -108,7 +106,7 @@ test("displays big logo image with alt title when big logo url is configured", f
108106
appendView();
109107

110108
ok(exists(fixture(bigLogoSelector)), "big logo image is present");
111-
equal(fixture(bigLogoSelector).attr("src"), "big-logo-url", "big logo image has correct source");
109+
equal(fixture(bigLogoSelector).attr("src"), bigLogoUrl, "big logo image has correct source");
112110
equal(fixture(bigLogoSelector).attr("alt"), "site-title", "big logo image has correct alt text");
113111
ok(!exists(fixture(headerSelector)), "header with title is not present");
114112
});

0 commit comments

Comments
 (0)