Fix delete user button on admin/user page so it's enabled at the right times, and update its title attribute to be more helpful

Author: nlalonde

app/assets/javascripts/admin/models/admin_user.js

@@ -202,12 +202,12 @@ Discourse.AdminUser = Discourse.User.extend({
   },
 
   deleteForbidden: function() {
-    return (this.get('post_count') > 0);
+    return (!this.get('can_be_deleted') || this.get('post_count') > 0);
   }.property('post_count'),
 
   deleteButtonTitle: function() {
     if (this.get('deleteForbidden')) {
-      return I18n.t('admin.user.delete_forbidden');
+      return I18n.t('admin.user.delete_forbidden', {count: Discourse.SiteSettings.delete_user_max_age});
     } else {
       return null;
     }

app/models/site_setting.rb

@@ -236,7 +236,7 @@ class SiteSetting < ActiveRecord::Base
 
   client_setting(:relative_date_duration, 14)
 
-  setting(:delete_user_max_age, 7)
+  client_setting(:delete_user_max_age, 7)
   setting(:delete_all_posts_max, 10)
 
 

config/locales/client.en.yml

@@ -1265,7 +1265,9 @@ en:
           and notified."
         time_read: "Read Time"
         delete: "Delete User"
-        delete_forbidden: "This user can't be deleted because there are posts. Delete all this user's posts first."
+        delete_forbidden:
+          one: "Users can't be deleted if they registered more than %{count} day ago, or if they have posts. Delete all posts before trying to delete a user."
+          other: "Users can't be deleted if they registered more than %{count} days ago, or if they have posts. Delete all posts before trying to delete a user."
         delete_confirm: "Are you SURE you want to permanently delete this user from the site? This action is permanent!"
         delete_and_block: "<b>Yes</b>, and <b>block</b> signups with the same email address"
         delete_dont_block: "<b>Yes</b>, and <b>allow</b> signups with the same email address"