Merge pull request discourse#1653 from ScotterC/uri-addressable

URI adapter should use Addressable

Author: eviltrout

app/services/uri_adapter.rb

@@ -6,14 +6,14 @@ class UriAdapter
   def initialize(target)
     raise Discourse::InvalidParameters unless target =~ /^https?:\/\//
 
-    @target = URI(target)
+    @target = Addressable::URI.parse(target)
     @original_filename = ::File.basename(@target.path)
     @content = download_content
     @tempfile = TempfileFactory.new.generate(@original_filename)
   end
 
   def download_content
-    open(target)
+    open(target.normalize)
   end
 
   def copy_to_tempfile(src)

spec/services/uri_adapter_spec.rb

@@ -14,7 +14,7 @@
   describe "#initialize" do
 
     it "has a target" do
-      subject.target.should be_instance_of(URI::HTTP)
+      subject.target.should be_instance_of(Addressable::URI)
     end
 
     it "has content" do
@@ -29,6 +29,27 @@
       subject.tempfile.should be_instance_of Tempfile
     end
 
+    describe "it handles ugly targets" do
+      let(:ugly_target) { "http://cdn.discourse.org/assets/logo with spaces.png" }
+      subject { UriAdapter.new(ugly_target) }
+
+      it "handles targets" do
+        subject.target.should be_instance_of(Addressable::URI)
+      end
+
+      it "has content" do
+        subject.content.should == response
+      end
+
+      it "has an original_filename" do
+        subject.original_filename.should == "logo with spaces.png"
+      end
+
+      it "has a tempfile" do
+        subject.tempfile.should be_instance_of Tempfile
+      end
+    end
+
   end
 
   describe "#copy_to_tempfile" do