Skip to content

Commit 57dcfd5

Browse files
committed
remove references to now-unused g:angular_filename_convention. remove now-useless test
1 parent 8a5d8ec commit 57dcfd5

4 files changed

Lines changed: 7 additions & 27 deletions

File tree

README.md

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -90,16 +90,9 @@ Results can be filtered by specifying exclusions in your .vimrc like this:
9090
let g:angular_find_ignore = ['build/', 'dist/']
9191
```
9292

93-
It does, by default, assume your filenames are dasherized (likeABoss or
94-
LikeABoss goes to like-a-boss.js). If you roll with likeABoss.js or
95-
LikeABoss.js, you can include the following in your .vimrc to make it do
96-
the right thing:
97-
98-
```
99-
let g:angular_filename_convention = 'camelcased'
100-
" or
101-
let g:angular_filename_convention = 'titlecased'
102-
```
93+
It does work in at least some cases regardless of whether your filenames are
94+
dasherized (likeABoss or LikeABoss goes to like-a-boss.js), camelcased
95+
(likeABoss.js), or titlecased (LikeABoss.js).
10396

10497
### Run the current spec
10598

doc/angular.txt

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,7 @@ gf Bolsters the original gf by also sending you to the
2222
the word under the cursor is a service/directive/etc,
2323
go to the file where it is defined. For example, if
2424
your cursor is on BlahService, it will take you to
25-
blah-service.js. If your filenames are not
26-
dasherized, this will not work out well. Set
27-
g:angular_filename_convention to either 'camelcased'
28-
or 'titlecased' in your .vimrc.
25+
blah-service.js.
2926

3027
*angular-:A*
3128
:A In a test file, edit the implementation, and vice

spec/gf_definition_spec.rb

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -24,33 +24,24 @@
2424
current_file_name.should eq "./app/js/piles-of-poo.js"
2525
end
2626

27-
specify "should be found when the filename-is-dasherized since that is the default g:angular_filename_convention" do
27+
specify "should be found when the filename-is-dasherized" do
2828
setup_filesystem('app/js/piles-of-poo.js')
2929
find_definition('pilesOfPoo')
3030
current_file_name.should eq "./app/js/piles-of-poo.js"
3131
end
3232

33-
specify "should be found when the filenameIsCamelcased and g:angular_filename_convention is set to camelcased" do
34-
assume_vimrc('let g:angular_filename_convention = "camelcased"')
33+
specify "should be found when the filenameIsCamelcased" do
3534
setup_filesystem('app/js/pilesOfPoo.js')
3635
find_definition('pilesOfPoo')
3736
current_file_name.should eq "./app/js/pilesOfPoo.js"
3837
end
3938

40-
specify "should be found when the FilenameIsTitlecased and g:angular_filename_convention is set to titlecased" do
41-
assume_vimrc('let g:angular_filename_convention = "titlecased"')
39+
specify "should be found when the FilenameIsTitlecased" do
4240
setup_filesystem('app/js/PilesOfPoo.js')
4341
find_definition('PilesOfPoo')
4442
current_file_name.should eq "./app/js/PilesOfPoo.js"
4543
end
4644

47-
specify "should not be found when the FilenameIsTitlecased and g:angular_filename_convention is set to something not supported" do
48-
assume_vimrc('let g:angular_filename_convention = "poopcased"')
49-
setup_filesystem('app/js/PilesOfPoo.js')
50-
find_definition('PilesOfPoo')
51-
current_file_name.should eq 'starting-file.js'
52-
end
53-
5445
specify "should be a champ about avoiding full stops" do
5546
setup_filesystem('app/js/piles-of-poo.js')
5647
find_definition('PilesOfPoo.keepingStinking()')

spec/spec_helper.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ def assume_vimrc(command)
4040
def assume_blank_vimrc_by_unsetting_any_global_variables
4141
vim.command('unlet g:angular_source_directory')
4242
vim.command('unlet g:angular_test_directory')
43-
vim.command('unlet g:angular_filename_convention')
4443
vim.command('unlet g:angular_jasmine_version')
4544
end
4645

0 commit comments

Comments
 (0)