Skip to content

Overflow occurs while trying to parse very large/small numbers #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jdm opened this issue Mar 31, 2015 · 2 comments
Closed

Overflow occurs while trying to parse very large/small numbers #72

jdm opened this issue Mar 31, 2015 · 2 comments

Comments

@jdm
Copy link
Member

jdm commented Mar 31, 2015

This leads to an unrecoverable panic, which is bad.
@jdm jdm changed the title Overflow occurs while trying to parse very large numbers Overflow occurs while trying to parse very large/small numbers Mar 31, 2015
@jdm
Copy link
Member Author

jdm commented Mar 31, 2015

Specifically, the parse::<f64>(val).unwrap() in consume_numeric in tokenizer.rs is the problem.

@SimonSapin
Copy link
Member

This is #35, which until now was purely theoretical. I’ll look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdm @SimonSapin