Mark derive with $crate::
#239
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
That's a breaking change, IIRC that's not supported by older Rust versions. If we make a breaking change we should rather remove hacks and use a proper procedural macro directly etc. |
Contributor
Author
|
Hmmm... CI fails with interesting errors :/ The support of this syntax is from 1.30, fwiw. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem currently that for example I create a procedural macro
cstr, if users usethe compiler would complain
This is because the custom derive macro is not imported. So if users want to use this macro, they would need to either use the traditional
#[macro_use] extern crate cstr;oruse cstr::*;. Neither is optimal.This PR adds
$crate::to the derive so that users of procedural macro can just import the macro they need.This change is