Skip to content

Commit d719ce1

Browse files
chore!: upgrade is-url-superb to ^4.0.0 (#125)
* chore!: upgrade is-url-superb to ^4.0.0 *Breaking*: Require Node.js 10 - remove url-regex dependency * chore: remove self-dep from perf test and update deps for audit Co-authored-by: shellscape <andrew@shellscape.org>
1 parent 38fafe9 commit d719ce1

File tree

4 files changed

+17
-100
lines changed

4 files changed

+17
-100
lines changed

lib/nodes/Word.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ class Word extends Node {
3737
const { value } = lastNode;
3838
lastNode.isColor = colorRegex.test(value) || colorNames.includes(value.toLowerCase());
3939
lastNode.isHex = hexRegex.test(value);
40-
lastNode.isUrl = isUrl(value);
40+
lastNode.isUrl = value.startsWith('//') ? isUrl(`http:${value}`) : isUrl(value);
4141
lastNode.isVariable = Word.testVariable(tokens[0], parser);
4242
}
4343

package-lock.json

Lines changed: 12 additions & 85 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"main": "lib/index.js",
1515
"types": "lib/index.d.ts",
1616
"engines": {
17-
"node": ">=6.14.4"
17+
"node": ">=10"
1818
},
1919
"scripts": {
2020
"ci:coverage": "nyc npm run test && nyc report --reporter=text-lcov > coverage.lcov",
@@ -31,9 +31,8 @@
3131
],
3232
"dependencies": {
3333
"color-name": "^1.1.4",
34-
"is-url-superb": "^3.0.0",
35-
"postcss": "^7.0.5",
36-
"url-regex": "^5.0.0"
34+
"is-url-superb": "^4.0.0",
35+
"postcss": "^7.0.5"
3736
},
3837
"devDependencies": {
3938
"ava": "^3.5.1",
@@ -44,7 +43,6 @@
4443
"nyc": "^15.0.0",
4544
"perfy": "^1.1.5",
4645
"postcss-value-parser": "^4.0.0",
47-
"postcss-values-parser": "^3.0.3",
4846
"pre-commit": "^1.2.2",
4947
"prettier": "^2.0.1",
5048
"strip-ansi": "^6.0.0",

perf/perf.js

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ const chalk = require('chalk');
55
const globby = require('globby');
66
const perfy = require('perfy');
77
const valueParser = require('postcss-value-parser');
8-
const v2Parser = require('postcss-values-parser');
8+
99
const strip = require('strip-ansi');
1010
const table = require('text-table');
1111

@@ -39,14 +39,6 @@ const { parse } = require('../');
3939
theirs = { milliseconds: NaN };
4040
}
4141

42-
perfy.start('v2');
43-
try {
44-
v2Parser(test).parse();
45-
v2 = perfy.end('v2');
46-
} catch (e) {
47-
v2 = { milliseconds: NaN };
48-
}
49-
5042
results.push({
5143
test,
5244
ours: ours.milliseconds,

0 commit comments

Comments
 (0)