Skip to content
This repository was archived by the owner on Aug 12, 2020. It is now read-only.

Update js files #26

Closed
ET-CS opened this issue Apr 29, 2013 · 4 comments
Closed

Update js files #26

ET-CS opened this issue Apr 29, 2013 · 4 comments

Comments

@ET-CS
Copy link
Collaborator

ET-CS commented Apr 29, 2013

Hello sigurdga.

I want to update to latest version of the js files from the source demo project: blueimp / jQuery-File-Upload. https://github.com/blueimp/jQuery-File-Upload

It will be very helpful, and will saves me a lot of time, if I knew what changes you've made to the files, if any, when creating this wonderful project.

Thank you in advance,
ET.

@sigurdga
Copy link
Owner

I don't think I changed anything to the js files. There may be breakages in that I may have used css or some inline js in the templates that may need changes after the update.

I would be glad if you told me about eventual problems you get into, as I would like to update the js files of this project as well.

@ET-CS
Copy link
Collaborator Author

ET-CS commented Jul 9, 2013

Updating the .js files break the demo when either 'main.js' or 'jquery-fileupload-ui.js' are updated. You may have any clue why this is happens? Do you remember what you have changed in the templates that may need changes?

@ET-CS
Copy link
Collaborator Author

ET-CS commented Aug 10, 2013

I have updated all the .js files, .css files.
Also needed to update the Templates and TemplatesTags.
Minor changed to the AJAX response in Views.url
Also created new view: /upload/view - to get the list of uploaded files on page load.

My commit:
https://github.com/ET-CS/django-jquery-file-upload/commit/db499d4d001ca8268cc9fa332aa4a96b19f2e2c3

@sigurdga
Copy link
Owner

I really have to thank you a lot for your effort. You have done a lot of work and I believe you understand more of the underlying javascript now than I do.

I had a few conflicts when I pulled your changes, which hadn't been there if you had pulled mine while you were working on it. You would have seen that I added a list of uploaded files as well. Just to let you know (and this change was at least three months old, I think). But as I had done this with simple Django, and you did it with the gallery widget of the upstream project, your version serves as a better example :)

So in the end, all of your changes should be there, and I think the least I can do is to give you commit access now that you have proven to know more about the upstream project than me.

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants