Skip to content

Commit 75e82c6

Browse files
remove replace from landscape
1 parent c08b052 commit 75e82c6

File tree

2 files changed

+4
-10
lines changed

2 files changed

+4
-10
lines changed

index.js

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -56,15 +56,9 @@ module.exports = postcss.plugin('postcss-px-to-viewport', function (options) {
5656
if (decl.value.indexOf(opts.unitToConvert) === -1) return;
5757
if (!satisfyPropList(decl.prop)) return;
5858

59-
var landscapeDecl = decl.clone({
59+
landscapeRule.append(decl.clone({
6060
value: decl.value.replace(pxRegex, createPxReplace(opts, opts.landscapeUnit, opts.landscapeWidth))
61-
});
62-
63-
if (opts.replace) {
64-
landscapeRule.append(landscapeDecl);
65-
} else {
66-
landscapeRule.append([decl.clone(), landscapeDecl]);
67-
}
61+
}));
6862
});
6963

7064
if (landscapeRule.nodes.length > 0) {

spec/px-to-viewport.spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -426,13 +426,13 @@ describe('landscape', function() {
426426
expect(processed).toBe(expected);
427427
});
428428

429-
it('should replace values inside landscape atRule', function() {
429+
it('should not replace values inside landscape atRule', function() {
430430
var options = {
431431
replace: false,
432432
landscape: true
433433
};
434434
var processed = postcss(pxToViewport(options)).process(basicCSS).css;
435-
var expected = '.rule { font-size: 15px; font-size: 4.6875vw }@media (orientation: landscape) {.rule { font-size: 15px; font-size: 2.64085vw } }';
435+
var expected = '.rule { font-size: 15px; font-size: 4.6875vw }@media (orientation: landscape) {.rule { font-size: 2.64085vw } }';
436436

437437
expect(processed).toBe(expected);
438438
});

0 commit comments

Comments
 (0)