Fix readLine() so can still detect start of line next time round

Also fix broken test: format was set to ignore empty lines, yet it checked for one

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306649 13f79535-47bb-0310-9956-ffa450edef68

Author: sebbASF

src/main/java/org/apache/commons/csv/ExtendedBufferedReader.java

@@ -123,9 +123,7 @@ public String readLine() throws IOException {
         String line = super.readLine();
 
         if (line != null) {
-            if (line.length() > 0) {
-                lastChar = line.charAt(line.length() - 1);
-            }
+            lastChar = '\n'; // needed for detecting start of line
             lineCounter++;
         } else {
             lastChar = END_OF_STREAM;

src/test/java/org/apache/commons/csv/CSVLexerTest.java

@@ -57,30 +57,33 @@ public void testNextToken1() throws IOException {
     @Test
     public void testNextToken2() throws IOException {
         final String code = 
-                "1,2,3,\n"+
-                "a,b x,c#no-comment\n"+
-                "#foo\n"+
-                "\n"+
-                "d,e,#no-comment\n"+
-                "# Final comment\n";
+                "1,2,3,\n"+                // 1
+                "a,b x,c#no-comment\n"+    // 2
+                "#foo\n"+                  // 3
+                "\n"+                      // 4
+                "d,e,#no-comment\n"+       // 5
+                "# penultimate comment\n"+ // 6
+                "# Final comment\n";       // 7
         CSVFormat format = CSVFormat.DEFAULT.withCommentStart('#');
+        assertTrue("Should ignore empty lines", format.isEmptyLinesIgnored());
 
         Lexer parser = getLexer(code, format);
 
 
         assertTokenEquals(TOKEN, "1", parser.nextToken(new Token()));
         assertTokenEquals(TOKEN, "2", parser.nextToken(new Token()));
         assertTokenEquals(TOKEN, "3", parser.nextToken(new Token()));
-        assertTokenEquals(EORECORD, "", parser.nextToken(new Token()));
+        assertTokenEquals(EORECORD, "", parser.nextToken(new Token()));             // 1
         assertTokenEquals(TOKEN, "a", parser.nextToken(new Token()));
         assertTokenEquals(TOKEN, "b x", parser.nextToken(new Token()));
-        assertTokenEquals(EORECORD, "c#no-comment", parser.nextToken(new Token()));
-        assertTokenEquals(COMMENT, "", parser.nextToken(new Token()));
-        assertTokenEquals(EORECORD, "", parser.nextToken(new Token()));
+        assertTokenEquals(EORECORD, "c#no-comment", parser.nextToken(new Token())); // 2
+        assertTokenEquals(COMMENT, "", parser.nextToken(new Token()));              // 3
+        // 4 empty line, ignored                                                    // 4
         assertTokenEquals(TOKEN, "d", parser.nextToken(new Token()));
         assertTokenEquals(TOKEN, "e", parser.nextToken(new Token()));
-        assertTokenEquals(EORECORD, "#no-comment", parser.nextToken(new Token()));
-        assertTokenEquals(COMMENT, "", parser.nextToken(new Token()));
+        assertTokenEquals(EORECORD, "#no-comment", parser.nextToken(new Token()));  // 5
+        assertTokenEquals(COMMENT, "", parser.nextToken(new Token()));              // 6
+        assertTokenEquals(COMMENT, "", parser.nextToken(new Token()));              // 7
         assertTokenEquals(EOF, "", parser.nextToken(new Token()));
         assertTokenEquals(EOF, "", parser.nextToken(new Token()));