Skip to content

Commit 8a683f0

Browse files
committed
CSV-75 ExtendedBufferReader does not handle EOL consistently
Fix tests git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1305695 13f79535-47bb-0310-9956-ffa450edef68
1 parent de1838e commit 8a683f0

1 file changed

Lines changed: 5 additions & 9 deletions

File tree

src/test/java/org/apache/commons/csv/ExtendedBufferedReaderTest.java

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -70,12 +70,12 @@ public void testReadLookahead1() throws Exception {
7070
assertEquals('3', br.readAgain());
7171

7272
assertEquals('\n', br.lookAhead());
73-
assertEquals(1, br.getLineNumber()); // will need fixing for CSV-75
73+
assertEquals(2, br.getLineNumber());
7474
assertEquals('3', br.readAgain());
7575
assertEquals('\n', br.read());
76-
assertEquals(2, br.getLineNumber()); // will need fixing for CSV-75
76+
assertEquals(3, br.getLineNumber());
7777
assertEquals('\n', br.readAgain());
78-
assertEquals(2, br.getLineNumber()); // will need fixing for CSV-75
78+
assertEquals(3, br.getLineNumber());
7979

8080
assertEquals(ExtendedBufferedReader.END_OF_STREAM, br.lookAhead());
8181
assertEquals('\n', br.readAgain());
@@ -152,16 +152,12 @@ public void testReadLine() throws Exception {
152152
/*
153153
* Test to illustrate https://issues.apache.org/jira/browse/CSV-75
154154
*
155-
* TODO fix checks when code is fixed
156155
*/
157156
@Test
158157
public void testReadChar() throws Exception {
159158
String LF="\n"; String CR="\r"; String CRLF=CR+LF; String LFCR=LF+CR;// easier to read the string below
160159
String test="a" + LF + "b" + CR + "c" + LF + LF + "d" + CR + CR + "e" + LFCR + "f "+ CRLF;
161160
// EOL eol EOL EOL eol eol EOL+CR EOL
162-
// EOL = current EOL behaviour with read() methods
163-
// eol = additional behaviour with readLine()
164-
final int EOLct=5;
165161
final int EOLeolct=9;
166162
ExtendedBufferedReader br;
167163

@@ -173,13 +169,13 @@ public void testReadChar() throws Exception {
173169
br = getBufferedReader(test);
174170
assertEquals(0, br.getLineNumber());
175171
while(br.read()!=-1) {}
176-
assertEquals(EOLct, br.getLineNumber()); // will need fixing for CSV-75
172+
assertEquals(EOLeolct, br.getLineNumber());
177173

178174
br = getBufferedReader(test);
179175
assertEquals(0, br.getLineNumber());
180176
char[] buff = new char[10];
181177
while(br.read(buff ,0, 3)!=-1) {}
182-
assertEquals(EOLct, br.getLineNumber()); // will need fixing for CSV-75
178+
assertEquals(EOLeolct, br.getLineNumber());
183179
}
184180

185181
private ExtendedBufferedReader getBufferedReader(String s) {

0 commit comments

Comments
 (0)