NET-279: Fix replyLines copying

Rory Winston · Rory Winston · commit 5eaac875d5c9 · 2009-06-02T21:17:05.000Z
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/net/branches/NET_2_0@781174 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/src/main/java/org/apache/commons/net/smtp/SMTP.java b/src/main/java/org/apache/commons/net/smtp/SMTP.java
@@ -442,10 +442,7 @@ public int getReply() throws IOException
      ***/
     public String[] getReplyStrings()
     {
-        String[] lines;
-        lines = new String[_replyLines.size()];
-        _replyLines.addAll(Arrays.asList(lines));
-        return lines;
+    	  return _replyLines.toArray(new String[_replyLines.size()]);
     }
 
     /***

Original file line number	Diff line number	Diff line change
`@@ -442,10 +442,7 @@ public int getReply() throws IOException`
`442`	`442`	`***/`
`443`	`443`	`public String[] getReplyStrings()`
`444`	`444`	`{`
`445`		`- String[] lines;`
`446`		`- lines = new String[_replyLines.size()];`
`447`		`- _replyLines.addAll(Arrays.asList(lines));`
`448`		`- return lines;`
	`445`	`+ return _replyLines.toArray(new String[_replyLines.size()]);`
`449`	`446`	`}`
`450`	`447`
`451`	`448`	`/***`