Skip to content

Commit 04c3a3b

Browse files
committed
Update to a shiny new Node 12/Ember 3.24 "old-app" test package
1 parent 5cd14f2 commit 04c3a3b

40 files changed

+6866
-3629
lines changed

test-packages/old-app/.editorconfig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44

55
root = true
66

7-
87
[*]
98
end_of_line = lf
109
charset = utf-8
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
# unconventional js
2+
/blueprints/*/files/
3+
/vendor/
4+
5+
# compiled output
6+
/dist/
7+
/tmp/
8+
9+
# dependencies
10+
/bower_components/
11+
/node_modules/
12+
13+
# misc
14+
/coverage/
15+
!.*
16+
.eslintcache
17+
18+
# ember-try
19+
/.node_modules.ember-try/
20+
/bower.json.ember-try
21+
/package.json.ember-try

test-packages/old-app/.eslintrc.js

Lines changed: 46 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,53 @@
1+
'use strict';
2+
13
module.exports = {
24
root: true,
5+
parser: 'babel-eslint',
36
parserOptions: {
4-
ecmaVersion: 2017,
5-
sourceType: 'module'
7+
ecmaVersion: 2018,
8+
sourceType: 'module',
9+
ecmaFeatures: {
10+
legacyDecorators: true,
11+
},
612
},
7-
extends: 'eslint:recommended',
13+
plugins: ['ember'],
14+
extends: [
15+
'eslint:recommended',
16+
'plugin:ember/recommended',
17+
'plugin:prettier/recommended',
18+
],
819
env: {
9-
browser: true
20+
browser: true,
1021
},
11-
rules: {
12-
}
22+
rules: {},
23+
overrides: [
24+
// node files
25+
{
26+
files: [
27+
'.eslintrc.js',
28+
'.prettierrc.js',
29+
'.template-lintrc.js',
30+
'ember-cli-build.js',
31+
'testem.js',
32+
'blueprints/*/index.js',
33+
'config/**/*.js',
34+
'lib/*/index.js',
35+
'server/**/*.js',
36+
],
37+
parserOptions: {
38+
sourceType: 'script',
39+
},
40+
env: {
41+
browser: false,
42+
node: true,
43+
},
44+
plugins: ['node'],
45+
extends: ['plugin:node/recommended'],
46+
rules: {
47+
// this can be removed once the following is fixed
48+
// https://github.com/mysticatea/eslint-plugin-node/issues/77
49+
'node/no-unpublished-require': 'off',
50+
},
51+
},
52+
],
1353
};

test-packages/old-app/.gitignore

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,26 @@
11
# See https://help.github.com/ignore-files/ for more about ignoring files.
22

33
# compiled output
4-
/dist
5-
/tmp
4+
/dist/
5+
/tmp/
66

77
# dependencies
8-
/node_modules
9-
/bower_components
8+
/bower_components/
9+
/node_modules/
1010

1111
# misc
12+
/.env*
13+
/.pnp*
1214
/.sass-cache
15+
/.eslintcache
1316
/connect.lock
14-
/coverage/*
17+
/coverage/
1518
/libpeerconnection.log
16-
npm-debug.log*
17-
yarn-error.log
18-
testem.log
19+
/npm-debug.log*
20+
/testem.log
21+
/yarn-error.log
1922

2023
# ember-try
21-
.node_modules.ember-try/
22-
bower.json.ember-try
23-
package.json.ember-try
24+
/.node_modules.ember-try/
25+
/bower.json.ember-try
26+
/package.json.ember-try
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
# unconventional js
2+
/blueprints/*/files/
3+
/vendor/
4+
5+
# compiled output
6+
/dist/
7+
/tmp/
8+
9+
# dependencies
10+
/bower_components/
11+
/node_modules/
12+
13+
# misc
14+
/coverage/
15+
!.*
16+
.eslintcache
17+
18+
# ember-try
19+
/.node_modules.ember-try/
20+
/bower.json.ember-try
21+
/package.json.ember-try
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
'use strict';
2+
3+
module.exports = {
4+
singleQuote: true,
5+
};
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
'use strict';
2+
3+
module.exports = {
4+
extends: 'octane',
5+
};

test-packages/old-app/.travis.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
---
22
language: node_js
33
node_js:
4-
- "6"
4+
- "10"
55

6-
sudo: false
7-
dist: trusty
6+
dist: xenial
87

98
addons:
109
chrome: stable
@@ -17,12 +16,13 @@ env:
1716
# See https://git.io/vdao3 for details.
1817
- JOBS=1
1918

19+
branches:
20+
only:
21+
- master
22+
2023
before_install:
2124
- curl -o- -L https://yarnpkg.com/install.sh | bash
2225
- export PATH=$HOME/.yarn/bin:$PATH
2326

24-
install:
25-
- yarn install --non-interactive
26-
2727
script:
2828
- yarn test

test-packages/old-app/README.md

Lines changed: 56 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,58 @@
11
# old-app
22

3-
This test package contains an app set up with the oldest ecosystem components we support:
4-
- `ember-cli@2.16`
5-
- `ember-cli-babel@6`
6-
- `ember-source@2.16`
7-
- `@ember-decorators/babel-transforms@2`
8-
- `broccoli-css-modules@0.7`
9-
- `broccoli-postcss@4`
10-
- `postcss@7`
11-
12-
Additionally, the test suite for this app is run under Node 6, as that's the oldest Node version we currently support.
13-
Because of that, it's not part of the yarn workspaces setup at the root of this repo, as many other transitive (development) dependencies have dropped support for older Node versions.
3+
This README outlines the details of collaborating on this Ember application.
4+
A short introduction of this app could easily go here.
5+
6+
## Prerequisites
7+
8+
You will need the following things properly installed on your computer.
9+
10+
* [Git](https://git-scm.com/)
11+
* [Node.js](https://nodejs.org/)
12+
* [Yarn](https://yarnpkg.com/)
13+
* [Ember CLI](https://ember-cli.com/)
14+
* [Google Chrome](https://google.com/chrome/)
15+
16+
## Installation
17+
18+
* `git clone <repository-url>` this repository
19+
* `cd old-app`
20+
* `yarn install`
21+
22+
## Running / Development
23+
24+
* `ember serve`
25+
* Visit your app at [http://localhost:4200](http://localhost:4200).
26+
* Visit your tests at [http://localhost:4200/tests](http://localhost:4200/tests).
27+
28+
### Code Generators
29+
30+
Make use of the many generators for code, try `ember help generate` for more details
31+
32+
### Running Tests
33+
34+
* `ember test`
35+
* `ember test --server`
36+
37+
### Linting
38+
39+
* `yarn lint:hbs`
40+
* `yarn lint:js`
41+
* `yarn lint:js --fix`
42+
43+
### Building
44+
45+
* `ember build` (development)
46+
* `ember build --environment production` (production)
47+
48+
### Deploying
49+
50+
Specify what it takes to deploy your app.
51+
52+
## Further Reading / Useful Links
53+
54+
* [ember.js](https://emberjs.com/)
55+
* [ember-cli](https://ember-cli.com/)
56+
* Development Browser Extensions
57+
* [ember inspector for chrome](https://chrome.google.com/webstore/detail/ember-inspector/bmdblncegkenkacieihfhpjfppoconhi)
58+
* [ember inspector for firefox](https://addons.mozilla.org/en-US/firefox/addon/ember-inspector/)

test-packages/old-app/app/app.js

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,12 @@
11
import Application from '@ember/application';
2-
import Resolver from './resolver';
2+
import Resolver from 'ember-resolver';
33
import loadInitializers from 'ember-load-initializers';
4-
import config from './config/environment';
4+
import config from 'old-app/config/environment';
55

6-
const App = Application.extend({
7-
modulePrefix: config.modulePrefix,
8-
podModulePrefix: config.podModulePrefix,
9-
Resolver
10-
});
6+
export default class App extends Application {
7+
modulePrefix = config.modulePrefix;
8+
podModulePrefix = config.podModulePrefix;
9+
Resolver = Resolver;
10+
}
1111

1212
loadInitializers(App, config.modulePrefix);
13-
14-
export default App;

0 commit comments

Comments
 (0)