OptionGroup.getOptions() already returns a Collection<Option> so there's no need to involve type cast

simonetripodi · simonetripodi · commit 8f77d1d0e28b · 2011-04-21T05:52:09.000Z
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/cli/trunk@1095599 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/src/main/java/org/apache/commons/cli/Options.java b/src/main/java/org/apache/commons/cli/Options.java
@@ -69,7 +69,7 @@ public class Options implements Serializable
      */
     public Options addOptionGroup(OptionGroup group)
     {
-        Iterator options = group.getOptions().iterator();
+        Iterator<Option> options = group.getOptions().iterator();
 
         if (group.isRequired())
         {
@@ -78,7 +78,7 @@ public Options addOptionGroup(OptionGroup group)
 
         while (options.hasNext())
         {
-            Option option = (Option) options.next();
+            Option option = options.next();
 
             // an Option cannot be required if it is in an
             // OptionGroup, either the group is required or

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ public class Options implements Serializable`
`69`	`69`	`*/`
`70`	`70`	`public Options addOptionGroup(OptionGroup group)`
`71`	`71`	`{`
`72`		`- Iterator options = group.getOptions().iterator();`
	`72`	`+ Iterator<Option> options = group.getOptions().iterator();`
`73`	`73`
`74`	`74`	`if (group.isRequired())`
`75`	`75`	`{`
`@@ -78,7 +78,7 @@ public Options addOptionGroup(OptionGroup group)`
`78`	`78`
`79`	`79`	`while (options.hasNext())`
`80`	`80`	`{`
`81`		`- Option option = (Option) options.next();`
	`81`	`+ Option option = options.next();`
`82`	`82`
`83`	`83`	`// an Option cannot be required if it is in an`
`84`	`84`	`// OptionGroup, either the group is required or`