Merge pull request creativecommons#522 from creativecommons/issue_finder_speed

Improve Issue Finder speed

Author: kgodey

themes/vocabulary_theme/templates/issue_finder.html

@@ -18,7 +18,7 @@ <h1>{{ this.title }}</h1>
         <noscript>
           The issue finder requires JavaScript. You can try searching on GitHub
           using the links below.
-          <ul>
+          <ul class="gh-links">
             <li>
               <a href="https://github.com/search?q=org%3Acreativecommons+is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22+-linked%3Apr">
                 issues labeled "good first issue"

webpack/js/components.js

@@ -1,5 +1,7 @@
 import VueSelect from 'vue-select';
 
+import {hydrateAppWithData} from "./hydration";
+
 export const IssueLabel = {
   template: `
 <span class="gh-label" :class="className">
@@ -25,7 +27,7 @@ export const IssueLabel = {
      * @returns {string} the name of the class to apply to the label
      */
     className() {
-      return window.categories[this.name] || 'miscellaneous'
+      return this.$root.categories[this.name] || 'miscellaneous'
     }
   }
 }
@@ -68,7 +70,7 @@ export const IssueCard = {
   },
   computed: {
     dateCreated() {
-      const dateCreated = new Date(this.issue.createdAt*1000)
+      const dateCreated = new Date(this.issue.createdAt * 1000)
       return dateCreated.toLocaleDateString()
     }
   }
@@ -80,7 +82,7 @@ export const App = {
 <div class="find-issues">
   <div class="columns">
     <div class="column is-one-quarter">
-      <form id="filters">
+      <form id="filters" v-if="options.skills.length">
         <label for="skills">
           <strong>Skill set</strong><br/>
           Choose up to three skills that you would like to see issues for.
@@ -108,6 +110,9 @@ export const App = {
           :reduce="experience => experience.code"
           :clearable="false"/>
       </form>
+      <div v-else>
+        Loading filters, please wait...
+      </div>
     </div>
     <div class="column">
       <template v-if="filteredIssues.length">
@@ -131,7 +136,7 @@ export const App = {
   data() {
     return {
       options: {
-        skills: window.skills,
+        skills: [],
         experiences: [
           {name: 'Yes, it is', code: 'beginner'},
           {name: 'No, it isn\'t', code: 'experienced'}
@@ -141,6 +146,7 @@ export const App = {
         skills: [],
         experience: 'experienced'
       },
+      categories: {},
       issues: []
     }
   },
@@ -166,5 +172,23 @@ export const App = {
         return true
       }).sort((a, b) => b.createdAt - a.createdAt)
     }
+  },
+  mounted() {
+    const BASE_URL = 'https://raw.githubusercontent.com/creativecommons/ccos-scripts/master/normalize_repos'
+    const FILE_URL = name => `${BASE_URL}/${name}.json`
+
+    Promise
+        .all([
+          fetch(FILE_URL('skills'))
+              .then(response => response.json()),
+          fetch(FILE_URL('labels'))
+              .then(response => response.json())
+        ])
+        .then(([skillResponse, labelResponse]) => {
+          const [skills, categories] = hydrateAppWithData(skillResponse, labelResponse)
+          this.categories = categories
+          this.options.skills = skills
+        })
+        .catch(err => console.error(err))
   }
-}
+}

webpack/js/hydration.js

@@ -1,14 +1,14 @@
-export const hydrateAppWithData = () => {
-  window.skills = Array.from( // Convert back into an array
+export const hydrateAppWithData = (skills, labels) => {
+  skills = Array.from( // Convert back into an array
       new Set( // Remove duplicates
-          Object.values(window.skills)
+          Object.values(skills)
               .flat() // Combine all skills
               .map(skill => skill.split('/')[0]) // Keep only the prefix
       )
   )
 
-  window.categories = {}
-  window.labels.groups.forEach(group => {
+  const categories = {}
+  labels.groups.forEach(group => {
     group.labels.forEach(label => {
       let name = label.name
       if (group.is_prefixed !== false) {
@@ -23,15 +23,17 @@ export const hydrateAppWithData = () => {
       } else {
         styleName = group.name
       }
-      window.categories[name] = styleName
+      categories[name] = styleName
     })
   })
-  window.labels.standalone.forEach(label => {
+  labels.standalone.forEach(label => {
     let name = `${label.emoji} ${label.name}`
-    window.categories[name] = 'miscellaneous'
+    categories[name] = 'miscellaneous'
   })
-  window.skills.forEach(skill => {
+  skills.forEach(skill => {
     let name = `💪 skill: ${skill.toLocaleLowerCase()}`
-    window.categories[name] = 'skill'
+    categories[name] = 'skill'
   })
-}
+
+  return [skills, categories]
+}

webpack/js/issue-finder.js

@@ -1,28 +1,6 @@
 import Vue from 'vue';
-
-import {hydrateAppWithData} from './hydration';
 import {App} from './components'
 
 $(document).ready(function () {
-  const BASE_URL = 'https://raw.githubusercontent.com/creativecommons/ccos-scripts/master/normalize_repos'
-  const FILE_URL = name => `${BASE_URL}/${name}.json`
-
-  Promise
-      .all([
-        fetch(FILE_URL('skills'))
-            .then(response => response.json())
-            .then(data => {
-              window.skills = data
-            }),
-        fetch(FILE_URL('labels'))
-            .then(response => response.json())
-            .then(data => {
-              window.labels = data
-            })
-      ])
-      .then(() => {
-        hydrateAppWithData()
-        window.app = new Vue(App)
-      })
-      .catch(err => console.error(err))
+  window.app = new Vue(App)
 })

webpack/sass/issue-finder-page.scss

@@ -8,7 +8,7 @@
 
     line-height: 1.8125;
 
-    ul {
+    ul.gh-links {
       list-style: disc;
       padding-left: 2em;
     }