Use API instead of system property

Use final

Author: garydgregory

src/main/java/org/apache/commons/csv/CSVPrinter.java

@@ -312,7 +312,7 @@ public synchronized void printRecord(final Stream<?> values) throws IOException
         values.forEachOrdered(t -> {
             try {
                 print(t);
-            } catch (IOException e) {
+            } catch (final IOException e) {
                 throw rethrow(e);
             }
         });
@@ -501,7 +501,7 @@ public void printRecords(final Stream<?> values) throws IOException {
         values.forEachOrdered(t -> {
             try {
                 printRecordObject(t);
-            } catch (IOException e) {
+            } catch (final IOException e) {
                 throw rethrow(e);
             }
         });

src/test/java/org/apache/commons/csv/CSVFormatTest.java

@@ -1567,6 +1567,6 @@ public void testWithRecordSeparatorLF() {
     @Test
     public void testWithSystemRecordSeparator() {
         final CSVFormat formatWithRecordSeparator = CSVFormat.DEFAULT.withSystemRecordSeparator();
-        assertEquals(System.getProperty("line.separator"), formatWithRecordSeparator.getRecordSeparator());
+        assertEquals(System.lineSeparator(), formatWithRecordSeparator.getRecordSeparator());
     }
 }

src/test/java/org/apache/commons/csv/CSVRecordTest.java

@@ -274,7 +274,7 @@ public void testStream() {
 
     @Test
     public void testToListAdd() {
-        String[] expected = values.clone();
+        final String[] expected = values.clone();
         final List<String> list = record.toList();
         list.add("Last");
         assertEquals("Last", list.get(list.size() - 1));
@@ -293,15 +293,15 @@ public void testToListFor() {
 
     @Test
     public void testToListForEach() {
-        AtomicInteger i = new AtomicInteger();
+        final AtomicInteger i = new AtomicInteger();
         record.toList().forEach(e -> {
             assertEquals(values[i.getAndIncrement()], e);
         });
     }
 
     @Test
     public void testToListSet() {
-        String[] expected = values.clone();
+        final String[] expected = values.clone();
         final List<String> list = record.toList();
         list.set(list.size() - 1, "Last");
         assertEquals("Last", list.get(list.size() - 1));