Skip to content

Commit 60c0f59

Browse files
author
Krystle Salazar
committed
Add images of post
1 parent a5a9180 commit 60c0f59

File tree

5 files changed

+19
-7
lines changed

5 files changed

+19
-7
lines changed
Loading

content/blog/entries/legal-database-features/contents.lr

+19-7
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,10 @@ In this post, I want to update the progress on Reimplementing the CC Legal Datab
1818

1919
The first thing I wanted to implement was the respective forms so that anyone can submit a case or article to the database. These forms were slightly modified in the redesign (discussed in the previous articles), so now it has fewer mandatory fields to lower the bar and facilitate the contribution of users.
2020

21-
[img: scholarship form]
21+
<figure style="text-align: center;">
22+
<img src="scholarship-form.png" alt="Form to submit an article related to CC licenses" style="border: 1px solid black; width: 60%;">
23+
<figcaption>Scholarship form to submit an article.</figcaption>
24+
</figure>
2225

2326
For the Scholarship form, for example, it is only needed to share your name, email and a link to propose an article related to any of the CC licenses, although the more information you can provide us the better, in any case, each contribution is reviewed by the staff before publishing.
2427

@@ -30,19 +33,28 @@ The second important task was to allow searching in each of the listings. A basi
3033

3134
While developing the mentioned functionalities I was also in charge of adding automatic unit tests, to ensure that future changes to the code base do not damage already functional parts of the site. This, in addition to giving more confidence to future contributors, they provide value immediately, at the time of writing the tests you should think about possible edge cases, so they allowed me to notice a missing validation in a couple of routes and then correct it.
3235

33-
[img: 404]
36+
<figure style="text-align: center;">
37+
<img src="404-page.png" alt="404 page" style="border:1px solid black; width:70%;">
38+
<figcaption>Example of page obtained when requesting a case detail that is not published or doesn't exist.</figcaption>
39+
</figure>
3440

35-
In this process of adding automated tests I wanted them to run on every pull request created, so I learned how to write a GitHub Action with a PostgreSQL service, the DBMS used in this case. Previously, I had already created a job for linting, so I needed to add another one to run in parallel to save time. This service provided by GitHub is pretty cool and useful, it opens up a world of possibilities. If you want to see the configuration file that makes this possible, I leave the link here for you.
41+
In this process of adding automated tests I wanted them to run on every pull request created, so I learned how to write a GitHub Action with a PostgreSQL service, the DBMS used in this case. Previously, I had already created a job for linting, so I needed to add another one to run in parallel to save time. This service provided by GitHub is pretty cool and useful, it opens up a world of possibilities. If you want to see the configuration file that makes this possible, check it out [here](https://github.com/creativecommons/caselaw/blob/31c3002a7860d78f3fdb464150c5c1b2f8bb86fc/.github/workflows/main.yml).
3642

37-
### Improved accessibility
43+
### Accessibility
3844

39-
To check if the site had shortcomings I did the Lighthouse test on it, discovering that there were indeed some issues to solve. In principle the results were these:
45+
To check if the site had shortcomings I did the Lighthouse test on the homepage, discovering that there were indeed some issues to tackle. In principle the results were these:
4046

41-
[img: test before]
47+
<figure style="text-align: center;">
48+
<img src="lighthouse-before.png" alt="" style="border:1px solid black; width:70%;">
49+
<figcaption>Initial Lighthouse test measurements.</figcaption>
50+
</figure>
4251

4352
The good thing about this test is that it throws up suggestions on how to fix the bugs found, so after adding certain missing attributes and labels, the following results were achieved.
4453

45-
[img: tests after]
54+
<figure style="text-align: center;">
55+
<img src="lighthouse-after.png" alt="" style="border:1px solid black; width:70%;">
56+
<figcaption>Lighthouse test measurements after corrections.</figcaption>
57+
</figure>
4658

4759
There is still room for improvement but at least we are within a quite acceptable green range.
4860

Loading
Loading
Loading

0 commit comments

Comments
 (0)