ASF Bugzilla Bug 30825

[codec] Under some circumstances Base64.isArrayByteBase64() throws a ArrayIndexOutOfBoundsException.
http://issues.apache.org/bugzilla/show_bug.cgi?id=30825


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/codec/trunk@130429 13f79535-47bb-0310-9956-ffa450edef68

Author: garydgregory

src/java/org/apache/commons/codec/binary/Base64.java

@@ -31,7 +31,7 @@
  * @see <a href="http://www.ietf.org/rfc/rfc2045.txt">RFC 2045</a>
  * @author Apache Software Foundation
  * @since 1.0-dev
- * @version $Id: Base64.java,v 1.22 2004/10/30 00:18:57 ggregory Exp $
+ * @version $Id: Base64.java,v 1.23 2004/11/24 19:23:25 ggregory Exp $
  */
 public class Base64 implements BinaryEncoder, BinaryDecoder {
 
@@ -153,10 +153,16 @@ public class Base64 implements BinaryEncoder, BinaryDecoder {
         lookUpBase64Alphabet[63] = (byte) '/';
     }
 
+    /**
+     * Returns whether or not the <code>octect</code> is in the base 64 alphabet.
+     * 
+     * @param octect The value to test
+     * @return <code>true</code> if the value is defined in the the base 64 alphabet, <code>false</code> otherwise.
+     */
     private static boolean isBase64(byte octect) {
         if (octect == PAD) {
             return true;
-        } else if (base64Alphabet[octect] == -1) {
+        } else if (octect < 0 || base64Alphabet[octect] == -1) {
             return false;
         } else {
             return true;

src/test/org/apache/commons/codec/binary/Base64Test.java

@@ -23,7 +23,7 @@
 import junit.framework.TestCase;
 
 /**
- * @version $Id: Base64Test.java,v 1.15 2004/04/19 01:14:29 ggregory Exp $
+ * @version $Id: Base64Test.java,v 1.16 2004/11/24 19:23:25 ggregory Exp $
  * @author Apache Software Foundation
  */
 public class Base64Test extends TestCase {
@@ -513,6 +513,17 @@ public void testIgnoringNonBase64InDecode() throws Exception {
 		assertEquals("The quick brown fox jumped over the lazy dogs.",new String(Base64.decodeBase64("VGhlIH@$#$@%F1aWN@#@#@@rIGJyb3duIGZve\n\r\t%#%#%#%CBqd##$#$W1wZWQgb3ZlciB0aGUgbGF6eSBkb2dzLg==".getBytes())));
 	}
 
+    public void testIsArrayByteBase64() {        
+        assertFalse(Base64.isArrayByteBase64(new byte[] {Byte.MIN_VALUE}));
+        assertFalse(Base64.isArrayByteBase64(new byte[] {-125}));
+        assertFalse(Base64.isArrayByteBase64(new byte[] {-10}));
+        assertFalse(Base64.isArrayByteBase64(new byte[] {0}));
+        assertFalse(Base64.isArrayByteBase64(new byte[] {64, Byte.MAX_VALUE}));
+        assertFalse(Base64.isArrayByteBase64(new byte[] {Byte.MAX_VALUE}));
+        assertTrue(Base64.isArrayByteBase64(new byte[] {'A'}));
+        assertFalse(Base64.isArrayByteBase64(new byte[] {'A', Byte.MIN_VALUE}));
+    }
+
     public void testObjectDecodeWithInvalidParameter() throws Exception {
         boolean exceptionThrown = false;