Skip to content

Commit a708c81

Browse files
authored
fixes image retention when no network is available (commons-app#5335)
1 parent b18bc8f commit a708c81

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.java

+6-5
Original file line numberDiff line numberDiff line change
@@ -604,11 +604,12 @@ private void setupImageView() {
604604
image.getHierarchy().setFailureImage(R.drawable.image_placeholder);
605605

606606
DraweeController controller = Fresco.newDraweeControllerBuilder()
607-
.setLowResImageRequest(ImageRequest.fromUri(media != null ? media.getThumbUrl() : null))
608-
.setImageRequest(ImageRequest.fromUri(media != null ? media.getImageUrl() : null))
609-
.setControllerListener(aspectRatioListener)
610-
.setOldController(image.getController())
611-
.build();
607+
.setLowResImageRequest(ImageRequest.fromUri(media != null ? media.getThumbUrl() : null))
608+
.setRetainImageOnFailure(true)
609+
.setImageRequest(ImageRequest.fromUri(media != null ? media.getImageUrl() : null))
610+
.setControllerListener(aspectRatioListener)
611+
.setOldController(image.getController())
612+
.build();
612613
image.setController(controller);
613614
}
614615

0 commit comments

Comments
 (0)