Skip to content

Commit 22b44be

Browse files
committed
CODEC-127 Convert to use Unicode in strings, but add comments in native encoding (utf-8)
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/codec/branches/generics@1157915 13f79535-47bb-0310-9956-ffa450edef68
1 parent 0c6a06c commit 22b44be

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

src/test/org/apache/commons/codec/language/ColognePhoneticTest.java

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,9 @@ public void testEdgeCases() throws EncoderException {
6464
{"i", "0"},
6565
{"o", "0"},
6666
{"u", "0"},
67-
{"\u00E4", "0"},
68-
{"\u00F6", "0"},
69-
{"\u00FC", "0"},
67+
{"\u00E4", "0"}, // a-umlaut
68+
{"\u00F6", "0"}, // o-umlaut
69+
{"\u00FC", "0"}, // u-umlaut
7070
{"aa", "0"},
7171
{"ha", "0"},
7272
{"h", ""},
@@ -94,20 +94,20 @@ public void testEdgeCases() throws EncoderException {
9494
@Test
9595
public void testExamples() throws EncoderException {
9696
String[][] data = {
97-
{"m\u00DCller", "657"},
97+
{"m\u00DCller", "657"}, // mÜller - why upper case U-umlaut?
9898
{"schmidt", "862"},
9999
{"schneider", "8627"},
100100
{"fischer", "387"},
101101
{"weber", "317"},
102102
{"wagner", "3467"},
103103
{"becker", "147"},
104104
{"hoffmann", "0366"},
105-
{"sch\u00C4fer", "837"},
105+
{"sch\u00C4fer", "837"}, // schÄfer - why upper case A-umlaut ?
106106
{"Breschnew", "17863"},
107107
{"Wikipedia", "3412"},
108108
{"peter", "127"},
109109
{"pharma", "376"},
110-
{"mönchengladbach", "664645214"},
110+
{"m\u00f6nchengladbach", "664645214"}, // mönchengladbach
111111
{"deutsch", "28"},
112112
{"deutz", "28"},
113113
{"hamburg", "06174"},
@@ -127,20 +127,21 @@ public void testExamples() throws EncoderException {
127127

128128
@Test
129129
public void testHyphen() throws EncoderException {
130-
String[][] data = {{"bergisch-gladbach", "174845214"}, {"Müller-Lüdenscheidt", "65752682"}};
130+
String[][] data = {{"bergisch-gladbach", "174845214"},
131+
{"M\u00fcller-L\u00fcdenscheidt", "65752682"}}; // Müller-Lüdenscheidt
131132
this.checkEncodings(data);
132133
}
133134

134135
@Test
135136
public void testIsEncodeEquals() {
136137
String[][] data = {
137-
{"Meyer", "Müller"},
138+
{"Meyer", "M\u00fcller"}, // Müller
138139
{"Meyer", "Mayr"},
139140
{"house", "house"},
140141
{"House", "house"},
141142
{"Haus", "house"},
142143
{"ganz", "Gans"},
143-
{"ganz", "Gänse"},
144+
{"ganz", "G\u00e4nse"}, // Gänse
144145
{"Miyagi", "Miyako"}};
145146
for (String[] element : data) {
146147
((ColognePhonetic) this.getStringEncoder()).isEncodeEqual(element[1], element[0]);

0 commit comments

Comments
 (0)