Skip to content

Commit 989116c

Browse files
committed
Use final
Remove unused imports
1 parent 93af662 commit 989116c

3 files changed

Lines changed: 7 additions & 9 deletions

File tree

src/test/java/org/apache/commons/csv/issues/JiraCsv198Test.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626

2727
import org.apache.commons.csv.CSVFormat;
2828
import org.apache.commons.csv.CSVParser;
29-
import org.apache.commons.csv.CSVRecord;
3029
import org.junit.jupiter.api.Test;
3130

3231
public class JiraCsv198Test {

src/test/java/org/apache/commons/csv/issues/JiraCsv211Test.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323

2424
import org.apache.commons.csv.CSVFormat;
2525
import org.apache.commons.csv.CSVParser;
26-
import org.apache.commons.csv.CSVRecord;
2726
import org.junit.jupiter.api.Test;
2827

2928
public class JiraCsv211Test {

src/test/java/org/apache/commons/csv/issues/JiraCsv290Test.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -55,12 +55,12 @@
5555
// 3 a b,c,d "quoted" e
5656
//
5757
public class JiraCsv290Test {
58-
private void testHelper(String filename, CSVFormat format) throws Exception {
59-
List<List<String>> content = new ArrayList<>();
58+
private void testHelper(final String filename, final CSVFormat format) throws Exception {
59+
final List<List<String>> content = new ArrayList<>();
6060
try (CSVParser csvParser = CSVParser.parse(new InputStreamReader(
6161
this.getClass().getResourceAsStream("/org/apache/commons/csv/CSV-290/" + filename)), format)) {
6262
for (CSVRecord csvRecord : csvParser) {
63-
List<String> row = new ArrayList<>();
63+
final List<String> row = new ArrayList<>();
6464
content.add(row);
6565
for (int i = 0; i < csvRecord.size(); i++) {
6666
row.add(csvRecord.get(i));
@@ -96,22 +96,22 @@ public void testPostgresqlText() throws Exception {
9696

9797
@Test
9898
public void testWriteThenRead() throws Exception {
99-
StringWriter sw = new StringWriter();
99+
final StringWriter sw = new StringWriter();
100100

101-
CSVPrinter printer = new CSVPrinter(sw,
101+
final CSVPrinter printer = new CSVPrinter(sw,
102102
CSVFormat.POSTGRESQL_CSV.builder().setHeader().setSkipHeaderRecord(true).build());
103103

104104
printer.printRecord("column1", "column2");
105105
printer.printRecord("v11", "v12");
106106
printer.printRecord("v21", "v22");
107107
printer.close();
108108

109-
CSVParser parser = new CSVParser(new StringReader(sw.toString()),
109+
final CSVParser parser = new CSVParser(new StringReader(sw.toString()),
110110
CSVFormat.POSTGRESQL_CSV.builder().setHeader().setSkipHeaderRecord(true).build());
111111

112112
assertArrayEquals(new Object[] { "column1", "column2" }, parser.getHeaderNames().toArray());
113113

114-
Iterator<CSVRecord> i = parser.iterator();
114+
final Iterator<CSVRecord> i = parser.iterator();
115115
assertArrayEquals(new String[] { "v11", "v12" }, i.next().toList().toArray());
116116
assertArrayEquals(new String[] { "v21", "v22" }, i.next().toList().toArray());
117117
}

0 commit comments

Comments
 (0)