Use isEmpty().

Author: garydgregory

src/test/java/org/apache/commons/cli/OptionGroupTest.java

@@ -73,7 +73,7 @@ public void testSingleOptionFromGroup() throws Exception
         assertTrue( "Confirm -d is NOT set", !cl.hasOption("d") );
         assertTrue( "Confirm -s is NOT set", !cl.hasOption("s") );
         assertTrue( "Confirm -c is NOT set", !cl.hasOption("c") );
-        assertTrue( "Confirm no extra args", cl.getArgList().size() == 0);
+        assertTrue( "Confirm no extra args", cl.getArgList().isEmpty());
     }
 
     @Test
@@ -88,7 +88,7 @@ public void testSingleOption() throws Exception
         assertTrue( "Confirm -d is NOT set", !cl.hasOption("d") );
         assertTrue( "Confirm -s is NOT set", !cl.hasOption("s") );
         assertTrue( "Confirm -c is NOT set", !cl.hasOption("c") );
-        assertTrue( "Confirm no extra args", cl.getArgList().size() == 0);
+        assertTrue( "Confirm no extra args", cl.getArgList().isEmpty());
     }
 
     @Test
@@ -103,7 +103,7 @@ public void testTwoValidOptions() throws Exception
         assertTrue( "Confirm -d is NOT set", !cl.hasOption("d") );
         assertTrue( "Confirm -s is NOT set", !cl.hasOption("s") );
         assertTrue( "Confirm -c is NOT set", !cl.hasOption("c") );
-        assertTrue( "Confirm no extra args", cl.getArgList().size() == 0);
+        assertTrue( "Confirm no extra args", cl.getArgList().isEmpty());
     }
 
     @Test
@@ -118,7 +118,7 @@ public void testSingleLongOption() throws Exception
         assertTrue( "Confirm -d is NOT set", !cl.hasOption("d") );
         assertTrue( "Confirm -s is NOT set", !cl.hasOption("s") );
         assertTrue( "Confirm -c is NOT set", !cl.hasOption("c") );
-        assertTrue( "Confirm no extra args", cl.getArgList().size() == 0);
+        assertTrue( "Confirm no extra args", cl.getArgList().isEmpty());
     }
 
     @Test
@@ -133,7 +133,7 @@ public void testTwoValidLongOptions() throws Exception
         assertTrue( "Confirm -d is NOT set", !cl.hasOption("d") );
         assertTrue( "Confirm -s is NOT set", !cl.hasOption("s") );
         assertTrue( "Confirm -c is NOT set", !cl.hasOption("c") );
-        assertTrue( "Confirm no extra args", cl.getArgList().size() == 0);
+        assertTrue( "Confirm no extra args", cl.getArgList().isEmpty());
     }
 
     @Test
@@ -198,7 +198,7 @@ public void testTwoOptionsFromDifferentGroup() throws Exception
         assertTrue( "Confirm -d is NOT set", !cl.hasOption("d") );
         assertTrue( "Confirm -s is set", cl.hasOption("s") );
         assertTrue( "Confirm -c is NOT set", !cl.hasOption("c") );
-        assertTrue( "Confirm NO extra args", cl.getArgList().size() == 0);
+        assertTrue( "Confirm NO extra args", cl.getArgList().isEmpty());
     }
 
     @Test

src/test/java/org/apache/commons/cli/ParserTestCase.java

@@ -227,7 +227,7 @@ public void testStopAtExpectedArg() throws Exception
 
         assertTrue("Confirm -b is set", cl.hasOption('b'));
         assertEquals("Confirm -b is set", "foo", cl.getOptionValue('b'));
-        assertTrue("Confirm no extra args: " + cl.getArgList().size(), cl.getArgList().size() == 0);
+        assertTrue("Confirm no extra args: " + cl.getArgList().size(), cl.getArgList().isEmpty());
     }
 
     @Test
@@ -676,7 +676,7 @@ public void testWithRequiredOption() throws Exception
         assertTrue("Confirm -a is NOT set", !cl.hasOption("a"));
         assertTrue("Confirm -b is set", cl.hasOption("b"));
         assertTrue("Confirm arg of -b", cl.getOptionValue("b").equals("file"));
-        assertTrue("Confirm NO of extra args", cl.getArgList().size() == 0);
+        assertTrue("Confirm NO of extra args", cl.getArgList().isEmpty());
     }
 
     @Test
@@ -693,7 +693,7 @@ public void testOptionAndRequiredOption() throws Exception
         assertTrue("Confirm -a is set", cl.hasOption("a"));
         assertTrue("Confirm -b is set", cl.hasOption("b"));
         assertTrue("Confirm arg of -b", cl.getOptionValue("b").equals("file"));
-        assertTrue("Confirm NO of extra args", cl.getArgList().size() == 0);
+        assertTrue("Confirm NO of extra args", cl.getArgList().isEmpty());
     }
 
     @Test