Skip to content

Commit d83153e

Browse files
committed
Bump maven-checkstyle-plugin from 2.15 to 3.1.1 apache#41.
1 parent 3ef0b69 commit d83153e

3 files changed

Lines changed: 12 additions & 15 deletions

File tree

pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@
233233
<plugin>
234234
<groupId>org.apache.maven.plugins</groupId>
235235
<artifactId>maven-checkstyle-plugin</artifactId>
236-
<version>2.15</version>
236+
<version>${commons.checkstyle-plugin.version}</version>
237237
<configuration>
238238
<configLocation>${basedir}/src/conf/checkstyle.xml</configLocation>
239239
<enableRulesSummary>false</enableRulesSummary>
@@ -269,7 +269,7 @@
269269
<plugin>
270270
<groupId>org.apache.maven.plugins</groupId>
271271
<artifactId>maven-checkstyle-plugin</artifactId>
272-
<version>2.15</version>
272+
<version>${commons.checkstyle-plugin.version}</version>
273273
<configuration>
274274
<configLocation>${basedir}/src/conf/checkstyle.xml</configLocation>
275275
<enableRulesSummary>false</enableRulesSummary>

src/changes/changes.xml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,10 @@
7373
</action>
7474
<action type="update" dev="ggregory" due-to="Dependabot">
7575
Bump maven-antrun-plugin from 1.7 to 3.0.0 #43.
76-
</action>
76+
</action>
77+
<action type="update" dev="ggregory" due-to="Gary Gregory">
78+
Bump maven-checkstyle-plugin from 2.15 to 3.1.1 #41.
79+
</action>
7780
</release>
7881

7982
<release version="1.4" date="2017-03-09" description="New features and bug fixes">

src/conf/checkstyle.xml

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ limitations under the License.
1717
-->
1818

1919
<!DOCTYPE module PUBLIC
20-
"-//Puppy Crawl//DTD Check Configuration 1.1//EN"
21-
"http://www.puppycrawl.com/dtds/configuration_1_1.dtd">
20+
"-//Checkstyle//DTD Checkstyle Configuration 1.3//EN"
21+
"https://checkstyle.org/dtds/configuration_1_3.dtd">
2222

2323
<!-- Checkstyle configuration that checks the commons-cli coding conventions -->
2424

@@ -47,16 +47,16 @@ limitations under the License.
4747
<property name="eachLine" value="true"/>
4848
</module>
4949

50-
<module name="TreeWalker">
50+
<module name="LineLength">
51+
<property name="max" value="120"/>
52+
</module>
5153

52-
<property name="cacheFile" value="${checkstyle.cache.file}"/>
54+
<module name="TreeWalker">
5355

5456
<!-- Checks for Javadoc comments. -->
5557
<!-- See http://checkstyle.sf.net/config_javadoc.html -->
5658
<module name="JavadocMethod">
5759
<property name="scope" value="public"/>
58-
<property name="allowUndeclaredRTE" value="true"/>
59-
<property name="allowMissingJavadoc" value="true"/>
6060
</module>
6161
<module name="JavadocType"/>
6262
<module name="JavadocVariable"/>
@@ -85,9 +85,6 @@ limitations under the License.
8585
<!-- Checks for Size Violations. -->
8686
<!-- See http://checkstyle.sf.net/config_sizes.html -->
8787
<!--<module name="FileLength"/>-->
88-
<module name="LineLength">
89-
<property name="max" value="120"/>
90-
</module>
9188
<module name="MethodLength"/>
9289
<module name="ParameterNumber">
9390
<property name="max" value="9"/>
@@ -135,9 +132,6 @@ limitations under the License.
135132
<module name="MagicNumber">
136133
<property name="ignoreNumbers" value="-1,0,1,2,3"/>
137134
</module>
138-
<module name="RedundantThrows">
139-
<property name="allowUnchecked" value="true"/>
140-
</module>
141135
<module name="SimplifyBooleanExpression"/>
142136
<module name="SimplifyBooleanReturn"/>
143137
<module name="StringLiteralEquality"/>

0 commit comments

Comments
 (0)