From 6d5ba97e30a6cefdc35f426c7c3b60b923eb9ed1 Mon Sep 17 00:00:00 2001 From: pflannery Date: Tue, 30 Jul 2013 21:18:40 +0100 Subject: [PATCH 1/3] Fixed duplicate Field Group Label->For attributes Field Group Label->"For" attributes were all referencing the same Id so when you click the second+ label in the group it always selected the first radio item. --- oocss/tools/files/handlebars.helpers.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/oocss/tools/files/handlebars.helpers.js b/oocss/tools/files/handlebars.helpers.js index f7771471..a9fd9cd0 100644 --- a/oocss/tools/files/handlebars.helpers.js +++ b/oocss/tools/files/handlebars.helpers.js @@ -140,7 +140,8 @@ var Handlebars, max = max*1; // parseint for (var i = start; i <= max; i++) { data.index = i; - data.indexStr = indexPrefix; + /* appends index to the indexStr so it's unique */ + data.indexStr = indexPrefix + i; str.push(options.fn(this, {data: data})); } return str.join(''); From 09f23064343b3a7d40cc66254aca5e5e9b11e877 Mon Sep 17 00:00:00 2001 From: pflannery Date: Tue, 30 Jul 2013 21:19:11 +0100 Subject: [PATCH 2/3] Fixed duplicate field group ids for email and select --- oocss/src/components/form/fieldGroup/fieldGroup.handlebars | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/oocss/src/components/form/fieldGroup/fieldGroup.handlebars b/oocss/src/components/form/fieldGroup/fieldGroup.handlebars index 6f9346d7..bafdf65c 100644 --- a/oocss/src/components/form/fieldGroup/fieldGroup.handlebars +++ b/oocss/src/components/form/fieldGroup/fieldGroup.handlebars @@ -59,7 +59,7 @@ {{#ffield}} {{#flabel "" "fieldLabel"}}Your email addresses{{/flabel}} {{#fgroup}} - {{#repeat 2 "inputblock"}} + {{#repeat 2 "emailInputblock"}} {{#fgroupitem "ftext" @indexStr "" ""}}Email address {{@index}}{{/fgroupitem}} {{/repeat}} {{/fgroup}} @@ -72,7 +72,7 @@ {{#ffield}} {{#flabel "" "fieldLabel"}}Select your options{{/flabel}} {{#fgroup}} - {{#repeat 2 "inputblock"}} + {{#repeat 2 "selectInputblock"}} {{#fgroupitem "fselect" @indexStr "" "" "" "" "" 2}}Option {{@index}}{{/fgroupitem}} {{/repeat}} {{/fgroup}} From b75df0bdf855b3ade8da447315fe592099f23a0b Mon Sep 17 00:00:00 2001 From: pflannery Date: Tue, 30 Jul 2013 21:27:30 +0100 Subject: [PATCH 3/3] Fixed single label using duplicate text1 id Renamed the Id to singleLabelText1 --- oocss/src/components/form/form_doc.handlebars | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/oocss/src/components/form/form_doc.handlebars b/oocss/src/components/form/form_doc.handlebars index 7e0e3d95..33f3fd3c 100644 --- a/oocss/src/components/form/form_doc.handlebars +++ b/oocss/src/components/form/form_doc.handlebars @@ -69,8 +69,8 @@

Add class labelLeft to label.

{{#formpres "" "" "htmlcode"}} {{#ffield}} - {{#flabel "text1" "labelLeft fieldLabel"}}Label on the left{{/flabel}} - {{#ftext "text1"}}{{/ftext}} + {{#flabel "singleLabelText1" "labelLeft fieldLabel"}}Label on the left{{/flabel}} + {{#ftext "singleLabelText1"}}{{/ftext}} {{/ffield}} {{/formpres}}
Multiple fields with label on left