Skip to content

Commit 735ec8e

Browse files
committed
test/review-shepherd: added workflow diagram
1 parent 064f78f commit 735ec8e

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

test/review-shepherd.txt

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,15 @@ This page describes the test submission and review process using [[http://test.c
88

99
Whether using this process or Github, test authors and reviewers must adhere to the [[https://github.com/w3c/testtwf-website/blob/gh-pages/docs/review-process.md| W3C Test Review Policy]]. FIXME
1010

11+
The general process looks like this:
12+
13+
{{:test:review-flowchart-v2.png|}}
14+
1115
==== Process for New Tests ====
1216
- Pre-condition: Test authors and reviewers must be set up with Mercurial access. See the [[tools:hg|Quick Guide to Mercurial]], including the section on [[tools:hg#obtaining-write-access|obtaining write access]].
1317
- When a test author is ready for tests to be reviewed, s/he must push them to the repository in a directory named ''submitted''. The tests will then be present in Shepherd as [[http://test.csswg.org/shepherd/search/status/submitted|Submitted for Review]].
1418
- The test author should then ask for a review on the <public-css-testsuite@w3.org> mailing list.
15-
- When a reviewer comes forward, s/he should examine the tests for correctness with respect to the [[https://github.com/w3c/testtwf-website/blob/gh-pages/docs/test-format-guidelines.md|format]] FIXME and [[https://github.com/w3c/testtwf-website/blob/gh-pages/docs/test-style-guidelines.md|style]] FIXME guidelines.
19+
- When a reviewer comes forward, s/he should examine the tests for correctness with respect to the [[https://github.com/w3c/testtwf-website/blob/gh-pages/docs/test-format-guidelines.md|format]] FIXME and [[https://github.com/w3c/testtwf-website/blob/gh-pages/docs/test-style-guidelines.md|style]] FIXME guidelines. A [[https://github.com/w3c/testtwf-website/blob/gh-pages/docs/review-checklist.md|short checklist]] FIXME is available to assist the reviewer and a more detailed [[test:css2.1:review-checklist|CSS-specific checklist]] is also available.
1620
- The reviewer should then notify the mailing list of the test review. It is not necessary to include all of the review feedback in the mail, just a link to the test suite in Shepherd.
1721
- **If the test passes review:** Go to the next step.
1822
- **If a test does not pass review:**
@@ -39,4 +43,4 @@ Currently, there are two such classifications:
3943

4044
* [[http://test.csswg.org/shepherd/search/spec/css21/status/issue/whiteboard/Metadata|Metadata]]: For tests requiring only a metadata change
4145
* [[http://test.csswg.org/shepherd/search/spec/css21/status/issue/whiteboard/Precision|Precision]]: For tests that are correct in some cases, but aren't precise enough to be correct in all cases
42-
* [[http://test.csswg.org/shepherd/search/spec/css21/status/issue/whiteboard/Incorrect|Incorrect]]: For tests that are incorrectly designed
46+
* [[http://test.csswg.org/shepherd/search/spec/css21/status/issue/whiteboard/Incorrect|Incorrect]]: For tests that are incorrectly designed

0 commit comments

Comments
 (0)