You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: test/review-shepherd.txt
+6-2Lines changed: 6 additions & 2 deletions
Original file line number
Diff line number
Diff line change
@@ -8,11 +8,15 @@ This page describes the test submission and review process using [[http://test.c
8
8
9
9
Whether using this process or Github, test authors and reviewers must adhere to the [[https://github.com/w3c/testtwf-website/blob/gh-pages/docs/review-process.md| W3C Test Review Policy]]. FIXME
10
10
11
+
The general process looks like this:
12
+
13
+
{{:test:review-flowchart-v2.png|}}
14
+
11
15
==== Process for New Tests ====
12
16
- Pre-condition: Test authors and reviewers must be set up with Mercurial access. See the [[tools:hg|Quick Guide to Mercurial]], including the section on [[tools:hg#obtaining-write-access|obtaining write access]].
13
17
- When a test author is ready for tests to be reviewed, s/he must push them to the repository in a directory named ''submitted''. The tests will then be present in Shepherd as [[http://test.csswg.org/shepherd/search/status/submitted|Submitted for Review]].
14
18
- The test author should then ask for a review on the <public-css-testsuite@w3.org> mailing list.
15
-
- When a reviewer comes forward, s/he should examine the tests for correctness with respect to the [[https://github.com/w3c/testtwf-website/blob/gh-pages/docs/test-format-guidelines.md|format]] FIXME and [[https://github.com/w3c/testtwf-website/blob/gh-pages/docs/test-style-guidelines.md|style]] FIXME guidelines.
19
+
- When a reviewer comes forward, s/he should examine the tests for correctness with respect to the [[https://github.com/w3c/testtwf-website/blob/gh-pages/docs/test-format-guidelines.md|format]] FIXME and [[https://github.com/w3c/testtwf-website/blob/gh-pages/docs/test-style-guidelines.md|style]] FIXME guidelines. A [[https://github.com/w3c/testtwf-website/blob/gh-pages/docs/review-checklist.md|short checklist]] FIXME is available to assist the reviewer and a more detailed [[test:css2.1:review-checklist|CSS-specific checklist]] is also available.
16
20
- The reviewer should then notify the mailing list of the test review. It is not necessary to include all of the review feedback in the mail, just a link to the test suite in Shepherd.
17
21
- **If the test passes review:** Go to the next step.
18
22
- **If a test does not pass review:**
@@ -39,4 +43,4 @@ Currently, there are two such classifications:
39
43
40
44
* [[http://test.csswg.org/shepherd/search/spec/css21/status/issue/whiteboard/Metadata|Metadata]]: For tests requiring only a metadata change
41
45
* [[http://test.csswg.org/shepherd/search/spec/css21/status/issue/whiteboard/Precision|Precision]]: For tests that are correct in some cases, but aren't precise enough to be correct in all cases
42
-
* [[http://test.csswg.org/shepherd/search/spec/css21/status/issue/whiteboard/Incorrect|Incorrect]]: For tests that are incorrectly designed
46
+
* [[http://test.csswg.org/shepherd/search/spec/css21/status/issue/whiteboard/Incorrect|Incorrect]]: For tests that are incorrectly designed
0 commit comments