Skip to content

Requiring users to append 'px' to react native units should be a linter preference and should not be done by this plugin #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shamilovtim opened this issue Dec 2, 2019 · 1 comment

Comments

@shamilovtim
Copy link

In v5.0.0-rc.0 this plugin has decided unilaterally and without much conversation that react native developers should be forced to append 'px' on their units. That is the job for a linter and it is a personal preference -- it is not the domain of this plugin. I appreciate the work everyone does here but I should not have other people's style decisions enforced over my code.

Please see https://facebook.github.io/react-native/docs/style. React Native units are unitless. Until the RN team decides otherwise this plugin is forcing devs to both write 'px' in styled-components and not write 'px' in vanilla RN components. That's messy and should not be the case.

Please provide a path for people to continue using unitless styles whether it be as a global setting or otherwise.

Screen Shot 2019-12-02 at 4 26 27 PM

@shamilovtim shamilovtim changed the title Forcing users to append 'px' to react native units is a linter preference and is not the role of this plugin Forcing users to append 'px' to react native units should be a linter preference and should not be done by this plugin Dec 2, 2019
@shamilovtim shamilovtim changed the title Forcing users to append 'px' to react native units should be a linter preference and should not be done by this plugin Requiring users to append 'px' to react native units should be a linter preference and should not be done by this plugin Dec 3, 2019
@quantizor quantizor transferred this issue from styled-components/styled-components Dec 24, 2019
@jacobp100
Copy link
Contributor

Please see #40 and surrounding discussions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants