-
Notifications
You must be signed in to change notification settings - Fork 83
API #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think we should have the default export be string => style map, but also expose declaration[] => stylemap. I don't think it's safe to assume 1 declaration = 1 property, since it would be nice to allow shorthands at some point. |
Sure, you go ahead then, I'm sure you've thought about this more than I have! :D |
I’ve settled on the following API. transform([
['border-width', '3 4'],
['font', '12/18 "Helvetica"'],
]); This is so we aren’t dependent on postCSS. People using postCSS can just do, transform(decls.map(decl => [decl.name, decl.value])); Should be ready unless you have further comments. |
Sounds good to me! |
Neat! Should be ready to publish—just run |
Sorry man, I totally dropped the ball on this! Back on it, let's land this! 🎉 |
Published v1.0.0 and added you on npm! |
|
You can totally do that yourself, I've added you on npm, but I'll do it this time! |
Just noticed that. Thanks! I’ve just added the prepublish hook now! |
Uh oh!
There was an error while loading. Please reload this page.
Not sure how much or little this module should do.
It could do the whole CSS string -> ReactNative object thing, but it could also just be responsible for the ReactNative specific styles:
In this case it would just check if it's one of the special reactnative declarations and then transform just those, otherwise return the value unchanged.
What do you think?
The text was updated successfully, but these errors were encountered: