added a safeguard to the scrollTarget value

Karl Swedberg · Karl Swedberg · commit fa01931af278 · 2010-06-06T21:13:51.000-04:00
diff --git a/jquery.smooth-scroll.js b/jquery.smooth-scroll.js
@@ -73,7 +73,7 @@ $.smoothScroll = function(options, px) {
     scrollTargetOffset = options;
   } else {
     opts = $.extend({}, $.fn.smoothScroll.defaults, options);
-    scrollTargetOffset = px || $(opts.scrollTarget).offset().top;
+    scrollTargetOffset = px || $(opts.scrollTarget).offset() && $(opts.scrollTarget).offset().top || 0;
   }
   opts = $.extend({link: null}, opts);
   

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ $.smoothScroll = function(options, px) {`
`73`	`73`	`scrollTargetOffset = options;`
`74`	`74`	`} else {`
`75`	`75`	`opts = $.extend({}, $.fn.smoothScroll.defaults, options);`
`76`		`- scrollTargetOffset = px \|\| $(opts.scrollTarget).offset().top;`
	`76`	`+ scrollTargetOffset = px \|\| $(opts.scrollTarget).offset() && $(opts.scrollTarget).offset().top \|\| 0;`
`77`	`77`	`}`
`78`	`78`	`opts = $.extend({link: null}, opts);`
`79`	`79`