Retain data and bindings on cloned last item.

Kai Schlamp · Kai Schlamp · commit b6a4cca79a55 · 2010-11-10T00:00:35.000+01:00
Some text adjustments as ticker is not very accurate.
diff --git a/tests/unit/ticker/ticker_core.js b/tests/unit/ticker/ticker_core.js
@@ -28,4 +28,27 @@ test("nextItem returns null", function() {
 	}, 100);
 });
 
+test("last item clone retains data and bindings", function() {
+	expect(3);
+	stop();
+
+	$("#ticker li:last")
+		.data("test", "123")
+		.bind("click", function() {});
+
+	$("#ticker").ticker({
+		initialTimeout: 0,
+		scrollTime: 0,
+		fadeTime: 0,
+		nextItem: function(lastItem) {
+			ok(true, "nextItem is called");
+			equals(lastItem.data("test"), "123", "last item clone retains data");
+			ok(lastItem.data("events") != null, "last item clone retains events");
+			return null;
+		}
+	});
+
+	window.setTimeout(function() { start(); }, 200);
+});
+
 })(jQuery);
diff --git a/tests/unit/ticker/ticker_events.js b/tests/unit/ticker/ticker_events.js
@@ -64,7 +64,7 @@ test("afterFade", function() {
 		}
 	});
 	
-	window.setTimeout(function() { start(); }, 200);
+	window.setTimeout(function() { start(); }, 300);
 });
 
 test("correct order of nextItem call and events", function() {
diff --git a/tests/unit/ticker/ticker_methods.js b/tests/unit/ticker/ticker_methods.js
@@ -85,21 +85,21 @@ test("start", function() {
 	var started = false;
 	
 	$("#ticker").ticker({
-		initialTimeout: 100,
-		mouseOnTimeout: 100,
-		mouseOffTimeout: 100,
-		scrollTime: 0,
-		fadeTime: 0,
+		active: false,
+		initialTimeout: 0,
 		nextItem: function(lastItem) {
 			if (started) {
 				ok(true, "ticker scrolled after it was started");
 				$("#ticker").ticker("stop");
 			}
+			else {
+				ok(false, "ticker scrolled without being started");
+			}
+
 		}
 	});
-	$("#ticker").ticker("stop");
 	window.setTimeout(function() { started = true; $("#ticker").ticker("start"); }, 200);
-	window.setTimeout(function() { start(); }, 500);
+	window.setTimeout(function() { start(); }, 600);
 });
 
 })(jQuery);
diff --git a/tests/unit/ticker/ticker_options.js b/tests/unit/ticker/ticker_options.js
@@ -81,7 +81,7 @@ test("{mouseOffTimeout: 100}", function() {
 		}
 	});
 	
-	window.setTimeout(function() { start(); }, 300 );
+	window.setTimeout(function() { start(); }, 400 );
 });
 
 test("{mouseOnTimeout: 100}", function() {
@@ -107,7 +107,7 @@ test("{mouseOnTimeout: 100}", function() {
 	});
 	
 	$("#ticker").simulate("mouseover");
-	window.setTimeout(function() { start(); }, 300 );
+	window.setTimeout(function() { start(); }, 400 );
 });
 
 test('{nextItem: function() {return $("TestItem")}}', function() {

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ test("afterFade", function() {`
`64`	`64`	`}`
`65`	`65`	`});`
`66`	`66`
`67`		`- window.setTimeout(function() { start(); }, 200);`
	`67`	`+ window.setTimeout(function() { start(); }, 300);`
`68`	`68`	`});`
`69`	`69`
`70`	`70`	`test("correct order of nextItem call and events", function() {`