Skip to content
This repository was archived by the owner on Apr 6, 2021. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: tailwindlabs/tailwindcss-jit
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: tailwindlabs/tailwindcss-jit
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: feat/variant-fallback
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 3 files changed
  • 1 contributor

Commits on Mar 28, 2021

  1. Fallback to non variant matches when no matching variant exists 

    Svelte’s dynamic class syntax looks like this:
<h1 class:text-blue-500={shouldBeBlue}></h1>

We were picking up `class:text-blue-500` as a variant. However `class` is not a registered variant. In this case we were discarding the already matched rules for text-blue-500. In this case we want to match them anyway.
    @thecrypticace
    thecrypticace committed Mar 28, 2021
    Configuration menu
    Copy the full SHA
    3e3c101 View commit details
    Browse the repository at this point in the history

  2. Refactor

    @thecrypticace
    thecrypticace committed Mar 28, 2021
    Configuration menu
    Copy the full SHA
    b2e0840 View commit details
    Browse the repository at this point in the history

  3. Don’t generate duplicate rule implementations 

    If multiple candidates resolved to the same rule the properties would get added more than once to the same rule.

For instance: class:text-blue-500 class1:text-blue-500 class2:text-blue-500 results in .text-blue-500 having the properties set 3 times.
    @thecrypticace
    thecrypticace committed Mar 28, 2021
    Configuration menu
    Copy the full SHA
    84404ce View commit details
    Browse the repository at this point in the history
Loading