This repository was archived by the owner on Apr 6, 2021. It is now read-only.
Support Svelte 'class:' syntax #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could the .svx extension be added too? It is the .mdx of svelte. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #71
This PR is an alternative to #178 that is a bit simpler, and just adds a little bit of Svelte-specific awareness to our internals to strip off any leading
class:only when reading a.sveltefile. There is a tiny performance cost to this, which is why I've opted to do it only on.sveltefiles and not on all files.I believe some older Svelte projects might use
.htmlas the file extension for Svelte stuff — personally I am totally comfortable telling those people to change the file extension if they need this feature or to override the default extractor.