Adress PR feedback

Author: philipp-spiess

packages/@tailwindcss-node/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tailwindcss/node",
-  "version": "4.0.0-alpha.19",
+  "version": "4.0.0-alpha.20",
   "description": "A utility-first CSS framework for rapidly building custom user interfaces.",
   "license": "MIT",
   "repository": {

packages/@tailwindcss-node/src/esm-cache.loader.mts

@@ -1,7 +1,7 @@
 import { isBuiltin, type ResolveHook } from 'node:module'
 
 export let resolve: ResolveHook = async (specifier, context, nextResolve) => {
-  const result = await nextResolve(specifier, context)
+  let result = await nextResolve(specifier, context)
 
   if (result.url === import.meta.url) return result
   if (isBuiltin(result.url)) return result

packages/@tailwindcss-node/src/get-module-dependencies.ts

@@ -19,9 +19,9 @@ const DEPENDENCY_PATTERNS = [
 //   c // .ts
 // a.js
 //   b // .js or .ts
-let jsExtensions = ['.js', '.cjs', '.mjs']
-let jsResolutionOrder = ['', '.js', '.cjs', '.mjs', '.ts', '.cts', '.mts', '.jsx', '.tsx']
-let tsResolutionOrder = ['', '.ts', '.cts', '.mts', '.tsx', '.js', '.cjs', '.mjs', '.jsx']
+const JS_EXTENSIONS = ['.js', '.cjs', '.mjs']
+const JS_RESOLUTION_ORDER = ['', '.js', '.cjs', '.mjs', '.ts', '.cts', '.mts', '.jsx', '.tsx']
+const TS_RESOLUTION_ORDER = ['', '.ts', '.cts', '.mts', '.tsx', '.js', '.cjs', '.mjs', '.jsx']
 
 async function resolveWithExtension(file: string, extensions: string[]) {
   // Try to find `./a.ts`, `./a.cts`, ... from `./a`
@@ -55,7 +55,7 @@ async function traceDependencies(
   ext: string,
 ): Promise<void> {
   // Try to find the file
-  let extensions = jsExtensions.includes(ext) ? jsResolutionOrder : tsResolutionOrder
+  let extensions = JS_EXTENSIONS.includes(ext) ? JS_RESOLUTION_ORDER : TS_RESOLUTION_ORDER
   let absoluteFile = await resolveWithExtension(path.resolve(base, filename), extensions)
   if (absoluteFile === null) return // File doesn't exist
 

packages/@tailwindcss-node/src/require-cache.cts

@@ -1,5 +1,5 @@
 export function clearRequireCache(files: string[]) {
-  for (const key of files) {
+  for (let key of files) {
     delete require.cache[key]
   }
 }

packages/tailwindcss/src/compat/config.test.ts

@@ -185,11 +185,11 @@ test('Config files can affect the theme', async ({ expect }) => {
     }),
   })
 
-  // TODO: This does not work yet but should
-  // expect(compiler.build(['bg-primary'])).toMatchInlineSnapshot()
-
-  expect(compiler.build(['scrollbar-primary'])).toMatchInlineSnapshot(`
-    ".scrollbar-primary {
+  expect(compiler.build(['bg-primary', 'scrollbar-primary'])).toMatchInlineSnapshot(`
+    ".bg-primary {
+      background-color: #c0ffee;
+    }
+    .scrollbar-primary {
       scrollbar-color: #c0ffee;
     }
     "

packages/tailwindcss/src/compat/dark-mode.ts

@@ -20,16 +20,14 @@ export function darkModePlugin({ addVariant, config }: PluginAPI) {
       for (let format of formats) {
         if (format === '.dark') {
           mode = false
-          console.warn('darkmode-variant-without-selector', [
-            'When using `variant` for `darkMode`, you must provide a selector.',
-            'Example: `darkMode: ["variant", ".your-selector &"]`',
-          ])
+          console.warn(
+            'When using `variant` for `darkMode`, you must provide a selector.\nExample: `darkMode: ["variant", ".your-selector &"]`',
+          )
         } else if (!format.includes('&')) {
           mode = false
-          console.warn('darkmode-variant-without-ampersand', [
-            'When using `variant` for `darkMode`, your selector must contain `&`.',
-            'Example `darkMode: ["variant", ".your-selector &"]`',
-          ])
+          console.warn(
+            'When using `variant` for `darkMode`, your selector must contain `&`.\nExample `darkMode: ["variant", ".your-selector &"]`',
+          )
         }
       }
     }