Revert "passthrough the extension to the Extractor itself"

This reverts commit 4ff21a3.

Author: RobinMalfait

crates/oxide/src/extractor/mod.rs

@@ -56,17 +56,15 @@ impl fmt::Display for Extracted<'_> {
 #[derive(Debug)]
 pub struct Extractor<'a> {
     cursor: cursor::Cursor<'a>,
-    extension: Option<&'a str>,
 
     css_variable_machine: CssVariableMachine,
     candidate_machine: CandidateMachine,
 }
 
 impl<'a> Extractor<'a> {
-    pub fn new(input: &'a [u8], extension: Option<&'a str>) -> Self {
+    pub fn new(input: &'a [u8]) -> Self {
         Self {
             cursor: cursor::Cursor::new(input),
-            extension,
 
             css_variable_machine: Default::default(),
             candidate_machine: Default::default(),
@@ -210,7 +208,7 @@ mod tests {
     }
 
     fn extract_sorted_candidates(input: &str) -> Vec<&str> {
-        let mut machine = Extractor::new(input.as_bytes(), None);
+        let mut machine = Extractor::new(input.as_bytes());
         let mut actual = machine
             .extract()
             .iter()
@@ -224,7 +222,7 @@ mod tests {
     }
 
     fn extract_sorted_css_variables(input: &str) -> Vec<&str> {
-        let mut machine = Extractor::new(input.as_bytes(), None);
+        let mut machine = Extractor::new(input.as_bytes());
         let mut actual = machine
             .extract()
             .iter()
@@ -289,12 +287,12 @@ mod tests {
             let input = include_bytes!("../fixtures/example.html");
 
             let throughput = Throughput::compute(iterations, input.len(), || {
-                let mut extractor = Extractor::new(input, None);
+                let mut extractor = Extractor::new(input);
                 _ = black_box(extractor.extract());
             });
             eprintln!("Extractor throughput: {:}", throughput);
 
-            let mut extractor = Extractor::new(input, None);
+            let mut extractor = Extractor::new(input);
             let start = std::time::Instant::now();
             _ = black_box(extractor.extract().len());
             let end = start.elapsed();

crates/oxide/src/extractor/pre_processors/pre_processor.rs

@@ -33,7 +33,7 @@ pub trait PreProcessor: Sized + Default {
         let processor = Self::default();
         let transformed = processor.process(input);
 
-        let extracted = Extractor::new(&transformed, None).extract();
+        let extracted = Extractor::new(&transformed).extract();
 
         // Extract all candidates and css variables.
         let candidates = extracted

crates/oxide/src/main.rs

@@ -5,7 +5,7 @@ use tailwindcss_oxide::extractor::{Extracted, Extractor};
 use tailwindcss_oxide::throughput::Throughput;
 
 fn run_full_extractor(input: &[u8]) -> Vec<&[u8]> {
-    Extractor::new(input, None)
+    Extractor::new(input)
         .extract()
         .into_iter()
         .map(|x| match x {

crates/oxide/src/scanner/mod.rs

@@ -327,7 +327,7 @@ impl Scanner {
         &mut self,
         changed_content: ChangedContent,
     ) -> Vec<(String, usize)> {
-        let (content, extension) = read_changed_content(changed_content).unwrap_or_default();
+        let content = read_changed_content(changed_content).unwrap_or_default();
         let original_content = &content;
 
         // Workaround for legacy upgrades:
@@ -337,7 +337,7 @@ impl Scanner {
         let content = content.replace("-[]", "XYZ");
         let offset = content.as_ptr() as usize;
 
-        let mut extractor = Extractor::new(&content[..], Some(&extension));
+        let mut extractor = Extractor::new(&content[..]);
 
         extractor
             .extract()
@@ -364,7 +364,7 @@ impl Scanner {
     }
 }
 
-fn read_changed_content(c: ChangedContent) -> Option<(Vec<u8>, String)> {
+fn read_changed_content(c: ChangedContent) -> Option<Vec<u8>> {
     let (content, extension) = match c {
         ChangedContent::File(file, extension) => match std::fs::read(&file) {
             Ok(content) => (content, extension),
@@ -377,7 +377,7 @@ fn read_changed_content(c: ChangedContent) -> Option<(Vec<u8>, String)> {
         ChangedContent::Content(contents, extension) => (contents.into_bytes(), extension),
     };
 
-    Some((pre_process_input(&content, &extension), extension))
+    Some(pre_process_input(&content, &extension))
 }
 
 pub fn pre_process_input(content: &[u8], extension: &str) -> Vec<u8> {
@@ -398,7 +398,7 @@ pub fn pre_process_input(content: &[u8], extension: &str) -> Vec<u8> {
 }
 
 #[tracing::instrument(skip_all)]
-fn read_all_files(changed_content: Vec<ChangedContent>) -> Vec<(Vec<u8>, String)> {
+fn read_all_files(changed_content: Vec<ChangedContent>) -> Vec<Vec<u8>> {
     event!(
         tracing::Level::INFO,
         "Reading {:?} file(s)",
@@ -412,16 +412,16 @@ fn read_all_files(changed_content: Vec<ChangedContent>) -> Vec<(Vec<u8>, String)
 }
 
 #[tracing::instrument(skip_all)]
-fn parse_all_blobs(blobs: Vec<(Vec<u8>, String)>) -> Vec<String> {
+fn parse_all_blobs(blobs: Vec<Vec<u8>>) -> Vec<String> {
     let mut result: Vec<_> = blobs
         .par_iter()
-        .flat_map(|(blob, extension)| blob.par_split(|x| *x == b'\n').map(move |x| (x, extension)))
-        .filter_map(|(blob, extension)| {
+        .flat_map(|blob| blob.par_split(|x| *x == b'\n'))
+        .filter_map(|blob| {
             if blob.is_empty() {
                 return None;
             }
 
-            let extracted = crate::extractor::Extractor::new(blob, Some(extension)).extract();
+            let extracted = crate::extractor::Extractor::new(blob).extract();
             if extracted.is_empty() {
                 return None;
             }