Ensure we hoist paths containing glob characters

Author: philipp-spiess

crates/oxide/src/glob.rs

@@ -86,6 +86,7 @@ pub fn optimize_public_source_entry(source: &mut PublicSourceEntry) {
         None => base,
     };
 
+    // TODO: If the base does not exist on disk, try removing the last slash and try again.
     let base = match dunce::canonicalize(&base) {
         Ok(base) => base,
         Err(err) => {

crates/oxide/tests/scanner.rs

@@ -836,6 +836,33 @@ mod scanner {
         assert_eq!(candidates, vec!["content-['keep-me.html']"]);
     }
 
+    #[test]
+    fn test_works_with_filenames_containing_glob_characters() {
+        // Create a temporary working directory
+        let dir = tempdir().unwrap().into_path();
+
+        // Create files
+        create_files_in(
+            &dir,
+            &[
+                ("src/app/[foo]/ignore-me.html", "content-['ignore-me.html']"),
+                ("src/app/[foo]/keep-me.html", "content-['keep-me.html']"),
+            ],
+        );
+
+        let sources = vec![
+            PublicSourceEntry::from_pattern(dir.clone(), "@source '**/*'"),
+            PublicSourceEntry::from_pattern(
+                dir.clone(),
+                "@source not 'src/app/[foo]/ignore*.html'",
+            ),
+        ];
+
+        let candidates = Scanner::new(sources.clone()).scan();
+
+        assert_eq!(candidates, vec!["content-['keep-me.html']"]);
+    }
+
     #[test]
     fn test_foo_bar() {
         // Create a temporary working directory