8000 Don't prefix arbitrary classes in `peer`/`group` variants by thecrypticace · Pull Request #11454 · tailwindlabs/tailwindcss · GitHub
Skip to content

Don't prefix arbitrary classes in peer/group variants #11454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thecrypticace merged 5 commits into from
Jun 28, 2023
Merged

Don't prefix arbitrary classes in peer/group variants #11454

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
988f29b
Refactor
thecrypticace Jun 19, 2023
1b651fc
Don’t prefix classes in arbitrary values for group and peer
thecrypticace Jun 28, 2023
8e2a3df
use `foo` instead of `lol`
RobinMalfait Jun 28, 2023
504fd19
handle the prefix inside the group/peer variants
RobinMalfait Jun 28, 2023
214794a
refactor to simple object instead
RobinMalfait Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use foo instead of lol
  • Loading branch information
@RobinMalfait
RobinMalfait committed Jun 28, 2023
commit 8e2a3df38f521182d2c4fd80ba35adcb8d0059ae
10 changes: 5 additions & 5 deletions tests/prefix.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,10 +615,10 @@ test('does not prefix arbitrary group/peer classes', async () => {
content: [
{
raw: html`
<div class="tw-group tw-peer lol">
<div class="group-[&.lol]:tw-flex"></div>
<div class="tw-group tw-peer foo">
<div class="group-[&.foo]:tw-flex"></div>
</div>
<div class="peer-[&.lol]:tw-flex"></div>
<div class="peer-[&.foo]:tw-flex"></div>
`,
},
],
Expand All @@ -632,8 +632,8 @@ test('does not prefix arbitrary group/peer classes', async () => {
const result = await run(input, config)

expect(result.css).toMatchFormattedCss(css`
.tw-group.lol .group-\[\&\.lol\]\:tw-flex,
.tw-peer.lol ~ .peer-\[\&\.lol\]\:tw-flex {
.tw-group.foo .group-\[\&\.foo\]\:tw-flex,
.tw-peer.foo ~ .peer-\[\&\.foo\]\:tw-flex {
display: flex;
}
`)
Expand Down