From 397908fe5fb4799dd48010bac58bbbd61d76eba9 Mon Sep 17 00:00:00 2001 From: Robin Malfait Date: Wed, 6 Mar 2024 16:39:33 +0100 Subject: [PATCH 1/2] improve CI by linting before building and intalling playwright browsers --- .github/workflows/ci.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8399c4b648d5..09f51924139a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -55,18 +55,18 @@ jobs: - name: Install dependencies run: pnpm install - - name: Install Playwright Browsers - run: npx playwright install --with-deps + - name: Lint + run: pnpm run lint - name: Build run: pnpm run build - - name: Lint - run: pnpm run lint - - name: Test run: pnpm run test + - name: Install Playwright Browsers + run: npx playwright install --with-deps + - name: Run Playwright tests run: npm run test:ui From 53f3fe5794144ea7fbe396cd98bb55c606afb30c Mon Sep 17 00:00:00 2001 From: Robin Malfait Date: Wed, 6 Mar 2024 16:45:58 +0100 Subject: [PATCH 2/2] move lint below build --- .github/workflows/ci.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 09f51924139a..4dbbe9cbbc41 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -23,6 +23,7 @@ jobs: - uses: pnpm/action-setup@v3 with: version: ^8.15.0 + - name: Use Node.js ${{ matrix.node-version }} uses: actions/setup-node@v3 with: @@ -55,12 +56,12 @@ jobs: - name: Install dependencies run: pnpm install - - name: Lint - run: pnpm run lint - - name: Build run: pnpm run build + - name: Lint + run: pnpm run lint + - name: Test run: pnpm run test