8000 Move modifier of `not-*`, `has-*`, and `in-*` variant to sub variant by RobinMalfait · Pull Request #19100 · tailwindlabs/tailwindcss · GitHub
Skip to content

Move modifier of not-*, has-*, and in-* variant to sub variant #19100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RobinMalfait merged 6 commits into from
Oct 9, 2025
Merged

Move modifier of not-*, has-*, and in-* variant to sub variant #19100

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9d61325
add failing test
RobinMalfait Oct 9, 2025
c4847c0
forward modifier of `not` and `has` variants to their subVariant
RobinMalfait Oct 9, 2025
1abc6b1
add test to ensure re-printing parsed variants work
RobinMalfait Oct 9, 2025
c6b640f
simplify: move the modifier _before_ parsing sub-variants
RobinMalfait Oct 9, 2025
cac6471
update changelog
RobinMalfait Oct 9, 2025
31e6662
handle `in-*` variant as well
RobinMalfait Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
forward modifier of not and has variants to their subVariant
  • Loading branch information
@RobinMalfait
RobinMalfait committed Oct 9, 2025
commit c4847c083a012ef4829337619e209d4410fc6b3b
14 changes: 14 additions & 0 deletions packages/tailwindcss/src/candidate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -809,6 +809,20 @@ export function parseVariant(variant: string, designSystem: DesignSystem): Varia
let subVariant = designSystem.parseVariant(value)
if (subVariant === null) return null

// Forward the modifier of the `not` and `has` variants to its
// subVariant. This allows for `not-group-hover/name:flex` to work.
if (modifier && (root === 'not' || root === 'has') && 'modifier' in subVariant) {
// Forward modifiers to the subVariant
let parsedModifier = parseModifier(modifier)
if (parsedModifier !== null) {
// Can't mutate directly because the `subVariant` is a shared
// object and then `group-hover` would be equivalent to
// `group-hover/name` which would be incorrect.
subVariant = { ...subVariant, modifier: parsedModifier }
modifier = null
}
}

// These two variants must be compatible when compounded
if (!designSystem.variants.compoundsWith(root, subVariant)) return null

Expand Down